linux-kernel - Re: [REGRESSION] spi: cadence-quadspi: STIG mode results in timeouts for Micron MT25QL01 flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed331ddc-9b61-459f-b7a9-90b7442d0166@pengutronix.de>
Date: Thu, 24 Oct 2024 09:12:11 +0200
From: Stefan Kerkmann <s.kerkmann@...gutronix.de>
To: Mark Brown <broonie@...nel.org>,
 Linux regressions mailing list <regressions@...ts.linux.dev>
Cc: Dhruva Gole <d-gole@...com>, Yoshitaka Ikeda <ikeda@...int.co.jp>,
 linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-team@...gutronix.de
Subject: Re: [REGRESSION] spi: cadence-quadspi: STIG mode results in timeouts
 for Micron MT25QL01 flash

Hello,

On 22.10.24 18:39, Mark Brown wrote:
> On Mon, Oct 21, 2024 at 11:58:07AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> 
>> The culprit afaics was merged for v6.3-rc1. Makes me wonder: would
>> reverting this now even an option to fix this in mainline, or would this
>> just lead to a regression for someone else?
> 
> Given the description of the original commit I'd expect so.  My guess
> would be that this is either tuning of the lengths involved or a quirk
> that's needed to disable STIG on some devices.

Adding a quirk came to my mind as well. I unfortunately do not have a different
QSPI chip to test against to see if it is a specific combination of peripheral
and chip  or if using STIG is generally broken on the socfpga. With trying
different lenghts do you refeer to `CQSPI_STIG_DATA_LEN_MAX`?

Regards,
Stefan

-- 
Pengutronix e.K.                       | Stefan Kerkmann             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-128  |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-9    |