| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d1264f6b-07bd-41e4-848d-1775a1f45884@kernel.org>
Date: Thu, 24 Oct 2024 11:45:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Karl.Li" <karl.li@...iatek.com>, Jassi Brar <jassisinghbrar@...il.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
<matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
Chungying Lu <chungying.lu@...iatek.com>,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 3/3] mailbox: mediatek: Add mtk-apu-mailbox driver
On 24/10/2024 11:25, Karl.Li wrote:
> From: Karl Li <karl.li@...iatek.com>
>
> Add mtk-apu-mailbox driver to support the communication with
> APU remote microprocessor.
>
> Also, the mailbox hardware contains extra spare (scratch) registers
> that other hardware blocks use to communicate through.
> Expose these with custom mtk_apu_mbox_(read|write)() functions.
>
> Signed-off-by: Karl Li <karl.li@...iatek.com>
> ---
> drivers/mailbox/Kconfig | 9 +
> drivers/mailbox/Makefile | 2 +
> drivers/mailbox/mtk-apu-mailbox.c | 222 ++++++++++++++++++++++++
> include/linux/mailbox/mtk-apu-mailbox.h | 20 +++
> 4 files changed, 253 insertions(+)
> create mode 100644 drivers/mailbox/mtk-apu-mailbox.c
> create mode 100644 include/linux/mailbox/mtk-apu-mailbox.h
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 6fb995778636..2338e08a110a 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -240,6 +240,15 @@ config MTK_ADSP_MBOX
> between processors with ADSP. It will place the message to share
> buffer and will access the ipc control.
>
> +config MTK_APU_MBOX
> + tristate "MediaTek APU Mailbox Support"
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> + help
> + Say yes here to add support for the MediaTek APU Mailbox
> + driver. The mailbox implementation provides access from the
> + application processor to the MediaTek AI Processing Unit.
> + If unsure say N.
> +
> config MTK_CMDQ_MBOX
> tristate "MediaTek CMDQ Mailbox Support"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile
> index 3c3c27d54c13..6b6dcc78d644 100644
> --- a/drivers/mailbox/Makefile
> +++ b/drivers/mailbox/Makefile
> @@ -53,6 +53,8 @@ obj-$(CONFIG_STM32_IPCC) += stm32-ipcc.o
>
> obj-$(CONFIG_MTK_ADSP_MBOX) += mtk-adsp-mailbox.o
>
> +obj-$(CONFIG_MTK_APU_MBOX) += mtk-apu-mailbox.o
> +
> obj-$(CONFIG_MTK_CMDQ_MBOX) += mtk-cmdq-mailbox.o
>
> obj-$(CONFIG_ZYNQMP_IPI_MBOX) += zynqmp-ipi-mailbox.o
> diff --git a/drivers/mailbox/mtk-apu-mailbox.c b/drivers/mailbox/mtk-apu-mailbox.c
> new file mode 100644
> index 000000000000..b347ebd34ef7
> --- /dev/null
> +++ b/drivers/mailbox/mtk-apu-mailbox.c
> @@ -0,0 +1,222 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2024 MediaTek Inc.
> + */
> +
> +#include <asm/io.h>
> +#include <linux/bits.h>
> +#include <linux/interrupt.h>
> +#include <linux/mailbox_controller.h>
> +#include <linux/mailbox/mtk-apu-mailbox.h>
> +#include <linux/platform_device.h>
> +
> +#define INBOX (0x0)
> +#define OUTBOX (0x20)
> +#define INBOX_IRQ (0xc0)
> +#define OUTBOX_IRQ (0xc4)
> +#define INBOX_IRQ_MASK (0xd0)
> +
> +#define SPARE_OFF_START (0x40)
> +#define SPARE_OFF_END (0xB0)
> +
> +struct mtk_apu_mailbox {
> + struct device *dev;
> + void __iomem *regs;
> + struct mbox_controller controller;
> + u32 msgs[MSG_MBOX_SLOTS];
> +};
> +
> +struct mtk_apu_mailbox *g_mbox;
Why this is global? And why do you support only one device?
No, drop.
> +
> +static irqreturn_t mtk_apu_mailbox_irq_top_half(int irq, void *dev_id)
> +{
> + struct mtk_apu_mailbox *mbox = dev_id;
> + struct mbox_chan *link = &mbox->controller.chans[0];
> + int i;
> +
> + for (i = 0; i < MSG_MBOX_SLOTS; i++)
> + mbox->msgs[i] = readl(mbox->regs + OUTBOX + i * sizeof(u32));
> +
> + mbox_chan_received_data(link, &mbox->msgs);
> +
> + return IRQ_WAKE_THREAD;
> +}
> +
...
> +/**
> + * mtk_apu_mbox_write - Write value to specifice mtk_apu_mbox spare register.
> + * @val: Value to be written.
> + * @offset: Offset of the spare register.
> + *
> + * Return: 0 if successful
> + * negative value if error happened
> + */
> +int mtk_apu_mbox_write(u32 val, u32 offset)
> +{
> + if (!g_mbox) {
> + pr_err("mtk apu mbox was not initialized, stop writing register\n");
> + return -ENODEV;
> + }
> +
> + if (offset < SPARE_OFF_START || offset >= SPARE_OFF_END) {
> + dev_err(g_mbox->dev, "Invalid offset %d for mtk apu mbox spare register\n", offset);
> + return -EINVAL;
> + }
> +
> + writel(val, g_mbox->regs + offset);
> + return 0;
> +}
> +EXPORT_SYMBOL_NS(mtk_apu_mbox_write, MTK_APU_MAILBOX);
Use mailbox API. This is really poor solution.
> +
> +/**
> + * mtk_apu_mbox_read - Read value to specifice mtk_apu_mbox spare register.
> + * @offset: Offset of the spare register.
> + * @val: Pointer to store read value.
> + *
> + * Return: 0 if successful
> + * negative value if error happened
> + */
> +int mtk_apu_mbox_read(u32 offset, u32 *val)
> +{
> + if (!g_mbox) {
> + pr_err("mtk apu mbox was not initialized, stop reading register\n");
> + return -ENODEV;
> + }
> +
> + if (offset < SPARE_OFF_START || offset >= SPARE_OFF_END) {
> + dev_err(g_mbox->dev, "Invalid offset %d for mtk apu mbox spare register\n", offset);
> + return -EINVAL;
> + }
> +
> + *val = readl(g_mbox->regs + offset);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_NS(mtk_apu_mbox_read, MTK_APU_MAILBOX);
> +
> +static int mtk_apu_mailbox_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct mtk_apu_mailbox *mbox;
> + int irq = -1, ret = 0;
> +
> + mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
> + if (!mbox)
> + return -ENOMEM;
> +
> + mbox->dev = dev;
> + platform_set_drvdata(pdev, mbox);
> +
> + mbox->regs = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(mbox->regs))
> + return PTR_ERR(mbox->regs);
> +
> + mbox->controller.txdone_irq = false;
> + mbox->controller.txdone_poll = true;
> + mbox->controller.txpoll_period = 1;
> + mbox->controller.ops = &mtk_apu_mailbox_ops;
> + mbox->controller.dev = dev;
> + /*
> + * Here we only register 1 mbox channel.
> + * The remaining channels are used by other modules.
> + */
> + mbox->controller.num_chans = 1;
> + mbox->controller.chans = devm_kcalloc(dev, mbox->controller.num_chans,
> + sizeof(*mbox->controller.chans),
> + GFP_KERNEL);
> + if (!mbox->controller.chans)
> + return -ENOMEM;
> +
> + ret = devm_mbox_controller_register(dev, &mbox->controller);
> + if (ret)
> + return ret;
> +
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> +
> + ret = devm_request_threaded_irq(dev, irq, mtk_apu_mailbox_irq_top_half,
> + mtk_apu_mailbox_irq_btm_half, IRQF_ONESHOT,
> + dev_name(dev), mbox);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to request IRQ\n");
> +
> + g_mbox = mbox;
> +
> + dev_dbg(dev, "registered mtk apu mailbox\n");
No, drop such stuff.
> +
> + return 0;
> +}
> +
> +static void mtk_apu_mailbox_remove(struct platform_device *pdev)
> +{
> + g_mbox = NULL;
> +}
> +
> +static const struct of_device_id mtk_apu_mailbox_of_match[] = {
> + { .compatible = "mediatek,mt8188-apu-mailbox" },
> + { .compatible = "mediatek,mt8196-apu-mailbox" },
So devices are compatible? Make them compatible in the binding and drop
unneeded compatible here.
Best regards,
Krzysztof
Powered by blists - more mailing lists