linux-kernel - Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024102406-shore-refurbish-767a@gregkh>
Date: Thu, 24 Oct 2024 11:47:18 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: jason-jh.lin@...iatek.com
Cc: Saravana Kannan <saravanak@...gle.com>, stable@...r.kernel.org,
	linux-kernel@...r.kernel.org, Seiya Wang <seiya.wang@...iatek.com>,
	Singo Chang <singo.chang@...iatek.com>
Subject: Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"

On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay wrote:
> From: "Jason-JH.Lin" <jason-jh.lin@...iatek.com>
> 
> This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> 
> Reason for revert:
> 1. The commit [1] does not land on linux-5.15, so this patch does not
> fix anything.
> 
> 2. Since the fw_device improvements series [2] does not land on
> linux-5.15, using device_set_fwnode() causes the panel to flash during
> bootup.
> 
> Incorrect link management may lead to incorrect device initialization,
> affecting firmware node links and consumer relationships.
> The fwnode setting of panel to the DSI device would cause a DSI
> initialization error without series[2], so this patch was reverted to
> avoid using the incomplete fw_devlink functionality.
> 
> [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
> [2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index 24606b632009..468a3a7cb6a5 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
>  		return dsi;
>  	}
>  
> -	device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> +	dsi->dev.of_node = info->node;
>  	dsi->channel = info->channel;
>  	strlcpy(dsi->name, info->type, sizeof(dsi->name));
>  
> 
> ---
> base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
> change-id: 20241024-fixup-5-15-5fdd68dae707
> 
> Best regards,
> -- 
> Jason-JH.Lin <jason-jh.lin@...iatek.com>
> 
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>