linux-kernel - Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88f78b11804b0f18e0dce0dca95544bf6cf6c7c6.camel@mediatek.com>
Date: Thu, 24 Oct 2024 10:16:05 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"saravanak@...gle.com" <saravanak@...gle.com>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, Seiya Wang (王迺君)
	<seiya.wang@...iatek.com>, Singo Chang (張興國)
	<Singo.Chang@...iatek.com>
Subject: Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"

Hi Greg,

Thanks for your information.

On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay
> wrote:
> > From: "Jason-JH.Lin" <jason-jh.lin@...iatek.com>
> > 
> > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > 
> > Reason for revert:
> > 1. The commit [1] does not land on linux-5.15, so this patch does
> not
> > fix anything.
> > 
> > 2. Since the fw_device improvements series [2] does not land on
> > linux-5.15, using device_set_fwnode() causes the panel to flash
> during
> > bootup.
> > 
> > Incorrect link management may lead to incorrect device
> initialization,
> > affecting firmware node links and consumer relationships.
> > The fwnode setting of panel to the DSI device would cause a DSI
> > initialization error without series[2], so this patch was reverted
> to
> > avoid using the incomplete fw_devlink functionality.
> > 
> > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> detection more robust")
> > [2] Link: 
> https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > 

Please don't mind me make a confirmation.
I just need to add this line here and send it again, right?

Cc: <stable@...r.kernel.org> #5.15.169

> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> > ---

Regards,
Jason-JH.Lin

> >  drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> b/drivers/gpu/drm/drm_mipi_dsi.c
> > index 24606b632009..468a3a7cb6a5 100644
> > --- a/drivers/gpu/drm/drm_mipi_dsi.c
> > +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> > @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
> mipi_dsi_host *host,
> >  return dsi;
> >  }
> >  
> > -device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> > +dsi->dev.of_node = info->node;
> >  dsi->channel = info->channel;
> >  strlcpy(dsi->name, info->type, sizeof(dsi->name));
> >  
> > 
> > ---
> > base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
> > change-id: 20241024-fixup-5-15-5fdd68dae707
> > 
> > Best regards,
> > -- 
> > Jason-JH.Lin <jason-jh.lin@...iatek.com>
> > 
> > 
> > 
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>