linux-kernel - [PATCH v2] usbip: tools: Fix detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241024022700.1236660-1-min_halo@163.com>
Date: Thu, 24 Oct 2024 10:27:00 +0800
From: Zongmin Zhou <min_halo@....com>
To: skhan@...uxfoundation.org
Cc: i@...ithal.me,
	linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	shuah@...nel.org,
	valentina.manea.m@...il.com,
	Zongmin Zhou <zhouzongmin@...inos.cn>,
	stable@...r.kernel.org
Subject: [PATCH v2] usbip: tools: Fix detach_port() invalid port error path

From: Zongmin Zhou <zhouzongmin@...inos.cn>

The detach_port() doesn't return error
when detach is attempted on an invalid port.

Fixes: 40ecdeb1a187 ("usbip: usbip_detach: fix to check for invalid ports")
Cc: stable@...r.kernel.org
Reviewed-by: Hongren Zheng <i@...ithal.me>
Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
Signed-off-by: Zongmin Zhou <zhouzongmin@...inos.cn>
---
 tools/usb/usbip/src/usbip_detach.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c
index b29101986b5a..6b78d4a81e95 100644
--- a/tools/usb/usbip/src/usbip_detach.c
+++ b/tools/usb/usbip/src/usbip_detach.c
@@ -68,6 +68,7 @@ static int detach_port(char *port)
 	}
 
 	if (!found) {
+		ret = -1;
 		err("Invalid port %s > maxports %d",
 			port, vhci_driver->nports);
 		goto call_driver_close;
-- 
2.34.1