[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241024123214.GB30704@willie-the-truck>
Date: Thu, 24 Oct 2024 13:32:14 +0100
From: Will Deacon <will@...nel.org>
To: Gowthami Thiagarajan <gthiagarajan@...vell.com>
Cc: mark.rutland@....com, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, gcherian@...vell.com,
sgoutham@...vell.com, lcherian@...vell.com
Subject: Re: [PATCH v9] perf/marvell: Marvell PEM performance monitor support
On Wed, Oct 16, 2024 at 06:44:57PM +0530, Gowthami Thiagarajan wrote:
> PCI Express Interface PMU includes various performance counters
> to monitor the data that is transmitted over the PCIe link. The
> counters track various inbound and outbound transactions which
> includes separate counters for posted/non-posted/completion TLPs.
> Also, inbound and outbound memory read requests along with their
> latencies can also be monitored. Address Translation Services(ATS)events
> such as ATS Translation, ATS Page Request, ATS Invalidation along with
> their corresponding latencies are also supported.
>
> The performance counters are 64 bits wide.
>
> For instance,
> perf stat -e ib_tlp_pr <workload>
> tracks the inbound posted TLPs for the workload.
>
> Signed-off-by: Gowthami Thiagarajan <gthiagarajan@...vell.com>
> Signed-off-by: Linu Cherian <lcherian@...vell.com>
I think this Signed-off-by: line from Linu is new in v9. What happened?
I notice that Linu is listed as the driver author:
> +MODULE_DESCRIPTION("Marvell PEM Perf driver");
> +MODULE_AUTHOR("Linu Cherian <lcherian@...vell.com>");
but the patch author is you, so git blame will be inconsistent.
Please can you make sure that MODULE_AUTHOR and the patch author are
consistent, and then use Co-developed-by as well as the additional SoB
for the second author?
Will
Powered by blists - more mailing lists