linux-kernel - Re: [PATCH v9] perf/marvell: Marvell PEM performance monitor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB3865C47C3668C312B96D19DBDB4A2@SJ0PR18MB3865.namprd18.prod.outlook.com>
Date: Mon, 28 Oct 2024 05:19:59 +0000
From: Gowthami Thiagarajan <gthiagarajan@...vell.com>
To: Will Deacon <will@...nel.org>
CC: "mark.rutland@....com" <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        George Cherian <gcherian@...vell.com>,
        Sunil
 Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>
Subject: Re: [PATCH v9] perf/marvell: Marvell PEM performance monitor support

Hi Will,

From: Will Deacon <will@...nel.org> 
Sent: Thursday, October 24, 2024 6:02 PM
To: Gowthami Thiagarajan <gthiagarajan@...vell.com>
Cc: mark.rutland@....com; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; George Cherian <gcherian@...vell.com>; Sunil Kovvuri Goutham <sgoutham@...vell.com>; Linu Cherian <lcherian@...vell.com>
Subject: [EXTERNAL] Re: [PATCH v9] perf/marvell: Marvell PEM performance monitor support

On Wed, Oct 16, 2024 at 06:44:57PM +0530, Gowthami Thiagarajan wrote:
> PCI Express Interface PMU includes various performance counters
> to monitor the data that is transmitted over the PCIe link. The
> counters track various inbound and outbound transactions which
> includes separate counters for posted/non-posted/completion TLPs.
> Also, inbound and outbound memory read requests along with their
> latencies can also be monitored. Address Translation Services(ATS)events
> such as ATS Translation, ATS Page Request, ATS Invalidation along with
> their corresponding latencies are also supported.
> 
> The performance counters are 64 bits wide.
> 
> For instance,
> perf stat -e ib_tlp_pr <workload>
> tracks the inbound posted TLPs for the workload.
> 
> Signed-off-by: Gowthami Thiagarajan <mailto:gthiagarajan@...vell.com>
> Signed-off-by: Linu Cherian <mailto:lcherian@...vell.com>

I think this Signed-off-by: line from Linu is new in v9. What happened?
I notice that Linu is listed as the driver author:

> +MODULE_DESCRIPTION("Marvell PEM Perf driver");
> +MODULE_AUTHOR("Linu Cherian <mailto:lcherian@...vell.com>");

but the patch author is you, so git blame will be inconsistent.

Please can you make sure that MODULE_AUTHOR and the patch author are
consistent, and then use Co-developed-by as well as the additional SoB
for the second author?

Had this discussed internally. I will change the MODULE_AUTHOR to myself and add the 
tags as suggested.

-Gowthami