linux-kernel - Re: [PATCH net] Documentation: ieee802154: fix grammar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxpLD3_oXlO1Ucb7@archie.me>
Date: Thu, 24 Oct 2024 20:26:39 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Leo Stone <leocstone@...il.com>, alex.aring@...il.com,
	stefan@...enfreihafen.org, miquel.raynal@...tlin.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, corbet@....net
Cc: linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org, anupnewmail@...il.com
Subject: Re: [PATCH net] Documentation: ieee802154: fix grammar

On Tue, Oct 22, 2024 at 09:12:01PM -0700, Leo Stone wrote:
> diff --git a/Documentation/networking/ieee802154.rst b/Documentation/networking/ieee802154.rst
> index c652d383fe10..743c0a80e309 100644
> --- a/Documentation/networking/ieee802154.rst
> +++ b/Documentation/networking/ieee802154.rst
> @@ -72,7 +72,8 @@ exports a management (e.g. MLME) and data API.
>  possibly with some kinds of acceleration like automatic CRC computation and
>  comparison, automagic ACK handling, address matching, etc.
>  
> -Those types of devices require different approach to be hooked into Linux kernel.
> +Each type of device requires a different approach to be hooked into the Linux
> +kernel.
>  
>  HardMAC
>  -------
> @@ -81,10 +82,10 @@ See the header include/net/ieee802154_netdev.h. You have to implement Linux
>  net_device, with .type = ARPHRD_IEEE802154. Data is exchanged with socket family
>  code via plain sk_buffs. On skb reception skb->cb must contain additional
>  info as described in the struct ieee802154_mac_cb. During packet transmission
> -the skb->cb is used to provide additional data to device's header_ops->create
> -function. Be aware that this data can be overridden later (when socket code
> -submits skb to qdisc), so if you need something from that cb later, you should
> -store info in the skb->data on your own.
> +the skb->cb is used to provide additional data to the device's
> +header_ops->create function. Be aware that this data can be overridden later
> +(when socket code submits skb to qdisc), so if you need something from that cb
> +later, you should store info in the skb->data on your own.
>  
>  To hook the MLME interface you have to populate the ml_priv field of your
>  net_device with a pointer to struct ieee802154_mlme_ops instance. The fields
> @@ -94,8 +95,9 @@ All other fields are required.
>  SoftMAC
>  -------
>  
> -The MAC is the middle layer in the IEEE 802.15.4 Linux stack. This moment it
> -provides interface for drivers registration and management of slave interfaces.
> +The MAC is the middle layer in the IEEE 802.15.4 Linux stack. At the moment, it
> +provides an interface for driver registration and management of slave
> +interfaces.
>  
>  NOTE: Currently the only monitor device type is supported - it's IEEE 802.15.4
>  stack interface for network sniffers (e.g. WireShark).

Looks good, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)