| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <8e6f209cbc2c33e445b544d13b06374338910d78.camel@collabora.com>
Date: Fri, 25 Oct 2024 13:45:44 -0400
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: Jonas Karlman <jonas@...boo.se>, Sebastian Fricke
<sebastian.fricke@...labora.com>, Ezequiel Garcia
<ezequiel@...guardiasur.com.ar>, Mauro Carvalho Chehab
<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Alex Bee <knaerzche@...il.com>, Benjamin Gaignard
<benjamin.gaignard@...labora.com>, Detlev Casanova
<detlev.casanova@...labora.com>, Dan Carpenter <dan.carpenter@...aro.org>,
linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, Christopher
Obbard <chris.obbard@...labora.com>
Subject: Re: [PATCH v6 10/11] media: rkvdec: h264: Support High 10 and 4:2:2
profiles
Le lundi 09 septembre 2024 à 19:25 +0000, Jonas Karlman a écrit :
> Add support and enable decoding of H264 High 10 and 4:2:2 profiles.
>
> Decoded CAPTURE buffer width is aligned to 64 pixels to accommodate HW
> requirement of 10-bit format buffers, fixes decoding of:
>
> - Hi422FR13_SONY_A
> - Hi422FR14_SONY_A
> - Hi422FR15_SONY_A
> - Hi422FR6_SONY_A
> - Hi422FR7_SONY_A
> - Hi422FR8_SONY_A
> - Hi422FR9_SONY_A
> - Hi422FREXT18_SONY_A
>
> The get_image_fmt() ops is implemented to select an image format
> required for the provided SPS control.
>
> Signed-off-by: Jonas Karlman <jonas@...boo.se>
> Tested-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>
> Tested-by: Christopher Obbard <chris.obbard@...labora.com>
> ---
> v6:
> - No change
>
> v5:
> - Move buffer align from rkvdec_fill_decoded_pixfmt to min/step_width
> - Use correct profiles for V4L2_CID_MPEG_VIDEO_H264_PROFILE
> - Collect t-b tags
>
> v4:
> - Change to use get_image_fmt() ops
>
> v3:
> - Add get_fmt_opaque ops, the expected pixelformat is used as opaque
> - Add new valid_fmt ops that validate pixelformat matches opaque
> - Update H264_PROFILE control max value
> ---
> drivers/staging/media/rkvdec/rkvdec-h264.c | 37 +++++++++++++++-----
> drivers/staging/media/rkvdec/rkvdec.c | 40 ++++++++++++++++------
> drivers/staging/media/rkvdec/rkvdec.h | 3 ++
> 3 files changed, 61 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec-h264.c b/drivers/staging/media/rkvdec/rkvdec-h264.c
> index 8bce8902b8dd..d14b4d173448 100644
> --- a/drivers/staging/media/rkvdec/rkvdec-h264.c
> +++ b/drivers/staging/media/rkvdec/rkvdec-h264.c
> @@ -1027,24 +1027,42 @@ static int rkvdec_h264_adjust_fmt(struct rkvdec_ctx *ctx,
> return 0;
> }
>
> +static enum rkvdec_image_fmt rkvdec_h264_get_image_fmt(struct rkvdec_ctx *ctx,
> + struct v4l2_ctrl *ctrl)
> +{
> + const struct v4l2_ctrl_h264_sps *sps = ctrl->p_new.p_h264_sps;
> +
> + if (ctrl->id != V4L2_CID_STATELESS_H264_SPS)
> + return RKVDEC_IMG_FMT_ANY;
> +
> + if (sps->bit_depth_luma_minus8 == 0) {
> + if (sps->chroma_format_idc == 2)
> + return RKVDEC_IMG_FMT_422_8BIT;
> + else
> + return RKVDEC_IMG_FMT_420_8BIT;
> + } else if (sps->bit_depth_luma_minus8 == 2) {
> + if (sps->chroma_format_idc == 2)
> + return RKVDEC_IMG_FMT_422_10BIT;
> + else
> + return RKVDEC_IMG_FMT_420_10BIT;
> + }
> +
> + return RKVDEC_IMG_FMT_ANY;
> +}
> +
> static int rkvdec_h264_validate_sps(struct rkvdec_ctx *ctx,
> const struct v4l2_ctrl_h264_sps *sps)
> {
> unsigned int width, height;
>
> - /*
> - * TODO: The hardware supports 10-bit and 4:2:2 profiles,
> - * but it's currently broken in the driver.
> - * Reject them for now, until it's fixed.
> - */
> - if (sps->chroma_format_idc > 1)
> - /* Only 4:0:0 and 4:2:0 are supported */
> + if (sps->chroma_format_idc > 2)
> + /* Only 4:0:0, 4:2:0 and 4:2:2 are supported */
> return -EINVAL;
> if (sps->bit_depth_luma_minus8 != sps->bit_depth_chroma_minus8)
> /* Luma and chroma bit depth mismatch */
> return -EINVAL;
> - if (sps->bit_depth_luma_minus8 != 0)
> - /* Only 8-bit is supported */
> + if (sps->bit_depth_luma_minus8 != 0 && sps->bit_depth_luma_minus8 != 2)
> + /* Only 8-bit and 10-bit is supported */
> return -EINVAL;
>
> width = (sps->pic_width_in_mbs_minus1 + 1) * 16;
> @@ -1190,4 +1208,5 @@ const struct rkvdec_coded_fmt_ops rkvdec_h264_fmt_ops = {
> .stop = rkvdec_h264_stop,
> .run = rkvdec_h264_run,
> .try_ctrl = rkvdec_h264_try_ctrl,
> + .get_image_fmt = rkvdec_h264_get_image_fmt,
> };
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index 8df49ee12820..c8c14f35ac44 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -195,10 +195,11 @@ static const struct rkvdec_ctrl_desc rkvdec_h264_ctrl_descs[] = {
> },
> {
> .cfg.id = V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> - .cfg.min = V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE,
> - .cfg.max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> + .cfg.min = V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_BASELINE,
The change from BASELINE to CONSTRAINED_BASELINE is correct, but it bugs me a
little to hide it into this patch. Do you mind splitting it out ?
Note that these days, since we have no software fallback for it, GStreamer, and
probably FFMPEG too, still try out contrained-baseline decoders for baseline
content, as very often the bitstream does not actually uses FMO and ASO
features. So perhaps we can just edit this one out to help with merging this
set?
With one of these two fix:
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>
> + .cfg.max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH_422_INTRA,
> .cfg.menu_skip_mask =
> - BIT(V4L2_MPEG_VIDEO_H264_PROFILE_EXTENDED),
> + BIT(V4L2_MPEG_VIDEO_H264_PROFILE_EXTENDED) |
> + BIT(V4L2_MPEG_VIDEO_H264_PROFILE_HIGH_444_PREDICTIVE),
> .cfg.def = V4L2_MPEG_VIDEO_H264_PROFILE_MAIN,
> },
> {
> @@ -213,11 +214,23 @@ static const struct rkvdec_ctrls rkvdec_h264_ctrls = {
> .num_ctrls = ARRAY_SIZE(rkvdec_h264_ctrl_descs),
> };
>
> -static const struct rkvdec_decoded_fmt_desc rkvdec_h264_vp9_decoded_fmts[] = {
> +static const struct rkvdec_decoded_fmt_desc rkvdec_h264_decoded_fmts[] = {
> {
> .fourcc = V4L2_PIX_FMT_NV12,
> .image_fmt = RKVDEC_IMG_FMT_420_8BIT,
> },
> + {
> + .fourcc = V4L2_PIX_FMT_NV15,
> + .image_fmt = RKVDEC_IMG_FMT_420_10BIT,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_NV16,
> + .image_fmt = RKVDEC_IMG_FMT_422_8BIT,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_NV20,
> + .image_fmt = RKVDEC_IMG_FMT_422_10BIT,
> + },
> };
>
> static const struct rkvdec_ctrl_desc rkvdec_vp9_ctrl_descs[] = {
> @@ -240,21 +253,28 @@ static const struct rkvdec_ctrls rkvdec_vp9_ctrls = {
> .num_ctrls = ARRAY_SIZE(rkvdec_vp9_ctrl_descs),
> };
>
> +static const struct rkvdec_decoded_fmt_desc rkvdec_vp9_decoded_fmts[] = {
> + {
> + .fourcc = V4L2_PIX_FMT_NV12,
> + .image_fmt = RKVDEC_IMG_FMT_420_8BIT,
> + },
> +};
> +
> static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
> {
> .fourcc = V4L2_PIX_FMT_H264_SLICE,
> .frmsize = {
> - .min_width = 48,
> + .min_width = 64,
> .max_width = 4096,
> - .step_width = 16,
> + .step_width = 64,
> .min_height = 48,
> .max_height = 2560,
> .step_height = 16,
> },
> .ctrls = &rkvdec_h264_ctrls,
> .ops = &rkvdec_h264_fmt_ops,
> - .num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts),
> - .decoded_fmts = rkvdec_h264_vp9_decoded_fmts,
> + .num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_decoded_fmts),
> + .decoded_fmts = rkvdec_h264_decoded_fmts,
> .subsystem_flags = VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF,
> },
> {
> @@ -269,8 +289,8 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
> },
> .ctrls = &rkvdec_vp9_ctrls,
> .ops = &rkvdec_vp9_fmt_ops,
> - .num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts),
> - .decoded_fmts = rkvdec_h264_vp9_decoded_fmts,
> + .num_decoded_fmts = ARRAY_SIZE(rkvdec_vp9_decoded_fmts),
> + .decoded_fmts = rkvdec_vp9_decoded_fmts,
> }
> };
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h
> index e466a2753ccf..9a9f4fced7a1 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.h
> +++ b/drivers/staging/media/rkvdec/rkvdec.h
> @@ -80,6 +80,9 @@ struct rkvdec_coded_fmt_ops {
> enum rkvdec_image_fmt {
> RKVDEC_IMG_FMT_ANY = 0,
> RKVDEC_IMG_FMT_420_8BIT,
> + RKVDEC_IMG_FMT_420_10BIT,
> + RKVDEC_IMG_FMT_422_8BIT,
> + RKVDEC_IMG_FMT_422_10BIT,
> };
>
> struct rkvdec_decoded_fmt_desc {
Powered by blists - more mailing lists