linux-kernel - Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241025071440.6tivzdzkkqacm27v@pengutronix.de>
Date: Fri, 25 Oct 2024 09:14:40 +0200
From: Marco Felsch <m.felsch@...gutronix.de>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: imx@...ts.linux.dev, Ulf Hansson <ulf.hansson@...aro.org>,
	Michael Trimarchi <michael@...rulasolutions.com>,
	linux-pm@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, linux-kernel@...r.kernel.org,
	Fabio Estevam <festevam@...il.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Dario Binacchi <dario.binacchi@...rulasolutions.com>,
	linux-amarula@...rulasolutions.com,
	Shengjiu Wang <shengjiu.wang@....com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with
 dev_err_probe()

Hi Dario,

On 24-10-24, Marco Felsch wrote:
> Hi Uwe,
> 
> On 24-10-24, Uwe Kleine-König wrote:
> > Hallo Marco,
> > 
> > On Thu, Oct 24, 2024 at 01:01:23PM +0200, Marco Felsch wrote:
> > > On 24-10-24, Dario Binacchi wrote:
> > > > The patch standardizes the probe() code by replacing the two occurrences
> > > > of dev_err() with dev_err_probe(). Indeed, dev_err_probe() was used in all
> > > > other error paths of the probe() function.
> > > 
> > > I assume that this paths aren't using dev_err_probe because these paths
> > > can't return EPROBE_DEFER and therefore dev_err_probe() would use
> > > dev_err() anyway.
> > 
> > Note that dev_err_probe() has advantages even if the error code isn't
> > EPROBE_DEFER. In this case it's mentioning the error code.
> > 
> > See also commits
> > 	7065f92255bb ("driver core: Clarify that dev_err_probe() is OK even w/out -EPROBE_DEFER")
> > 	532888a59505 ("driver core: Better advertise dev_err_probe()")
> 
> thanks for the pointers. With that in mind it make sense to me to
> convert it. Feel free to add my:

that being said, I would like to ask you if you could addapt the commit
message, to point out the advantage of using dev_err_probe().

> Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>
> 
> Regards,
>   Marco
> 
>