linux-kernel - RE: [PATCH v4 net-next 03/13] dt-bindings: net: add bindings for NETC blocks control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85108DAF7FA67BC1B36CB6FF884F2@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 25 Oct 2024 07:15:07 +0000
From: Wei Fang <wei.fang@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, Claudiu
 Manoil <claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>, Frank Li
	<frank.li@....com>, "christophe.leroy@...roup.eu"
	<christophe.leroy@...roup.eu>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"horms@...nel.org" <horms@...nel.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>
Subject: RE: [PATCH v4 net-next 03/13] dt-bindings: net: add bindings for NETC
 blocks control

> On 23/10/2024 12:03, Wei Fang wrote:
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@...nel.org>
> >> Sent: 2024年10月23日 16:56
> >> To: Wei Fang <wei.fang@....com>
> >> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> >> pabeni@...hat.com; robh@...nel.org; krzk+dt@...nel.org;
> >> conor+dt@...nel.org; Vladimir Oltean <vladimir.oltean@....com>;
> >> conor+Claudiu
> >> Manoil <claudiu.manoil@....com>; Clark Wang
> <xiaoning.wang@....com>;
> >> Frank Li <frank.li@....com>; christophe.leroy@...roup.eu;
> >> linux@...linux.org.uk; bhelgaas@...gle.com; horms@...nel.org;
> >> imx@...ts.linux.dev; netdev@...r.kernel.org;
> >> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> >> linux-pci@...r.kernel.org; alexander.stein@...tq-group.com
> >> Subject: Re: [PATCH v4 net-next 03/13] dt-bindings: net: add bindings
> >> for NETC blocks control
> >>
> >> On 23/10/2024 10:18, Wei Fang wrote:
> >>>>> +maintainers:
> >>>>> +  - Wei Fang <wei.fang@....com>
> >>>>> +  - Clark Wang <xiaoning.wang@....com>
> >>>>> +
> >>>>> +properties:
> >>>>> +  compatible:
> >>>>> +    enum:
> >>>>> +      - nxp,imx95-netc-blk-ctrl
> >>>>> +
> >>>>> +  reg:
> >>>>> +    minItems: 2
> >>>>> +    maxItems: 3
> >>>>
> >>>> You have one device, why this is flexible? Device either has
> >>>> exactly
> >>>> 2 or exactly 3 IO spaces, not both depending on the context.
> >>>>
> >>>
> >>> There are three register blocks, IERB and PRB are inside NETC IP,
> >>> but NETCMIX is outside NETC. There are dependencies between these
> >>> three blocks, so it is better to configure them in one driver. But
> >>> for other platforms like S32, it does not have NETCMIX, so NETCMIX is
> optional.
> >>
> >> But how s32 is related here? That's a different device.
> >>
> >
> > The S32 SoC also uses the NETC IP, so this YAML should be compatible
> > with
> > S32 SoC.
> 
> What? How? Where is this compatible documented?
> 

Yes, it is not added yet, so that is why I asked the below question. I should
only focus on i.MX95.


> > Or do you mean when S32 NETC is supported, we then add restrictions to
> > the reg property for S32?
> 
> I don't know what you are creating here. That's a binding for one specific device
> (see writing bindings guideline).
>