linux-kernel - Re: [PATCH v2 2/2] firmware: add exynos acpm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c889ceae-f605-49e8-8aa6-e6d7fc78a641@linaro.org>
Date: Fri, 25 Oct 2024 10:44:49 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Alim Akhtar <alim.akhtar@...sung.com>, krzk@...nel.org
Cc: mst@...hat.com, javierm@...hat.com, tzimmermann@...e.de,
 bartosz.golaszewski@...aro.org, luzmaximilian@...il.com,
 sudeep.holla@....com, conor.dooley@...rochip.com, bjorn@...osinc.com,
 ulf.hansson@...aro.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 marcan@...can.st, neal@...pa.dev, alyssa@...enzweig.io, broonie@...nel.org,
 andre.draszik@...aro.org, willmcvicker@...gle.com, peter.griffin@...aro.org,
 kernel-team@...roid.com, vincent.guittot@...aro.org,
 daniel.lezcano@...aro.org, Jassi Brar <jassisinghbrar@...il.com>
Subject: Re: [PATCH v2 2/2] firmware: add exynos acpm driver



On 10/21/24 5:47 PM, Alim Akhtar wrote:
> Hi Tudor

Hi, Alim!

Thanks for the review!

>> diff --git a/drivers/firmware/samsung/Kconfig
>> b/drivers/firmware/samsung/Kconfig
>> new file mode 100644
>> index 000000000000..f908773c1441
>> --- /dev/null
>> +++ b/drivers/firmware/samsung/Kconfig
>> @@ -0,0 +1,11 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +
>> +config EXYNOS_ACPM
> 
> This looks misleading to me, as you mentioned below, ACPM is a FW which runs
> on APM module, and 
> The proposed driver is a communication method between Application processor
> and APM module,
> Which is via MAILBOX.
> So preferably EXYNOS_MAILBOX_APM is more meaningful here.

This seems more accurate indeed. The design document that I have refers
to the protocol as "ACPM IPC", so maybe I shall stick with EXYNOS_ACPM_IPC.

I'll also need to prefix all the definitions in the driver with
exynos_acpm_ipc_* which will result in long names. But I guess there's
nothing we can do about it.

Cheers,
ta