linux-kernel - Re: [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zxuc1HWTIiUJ3Rwo@smile.fi.intel.com>
Date: Fri, 25 Oct 2024 16:27:48 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI
 instantiated i2c_client

On Fri, Oct 25, 2024 at 10:37:12AM +0200, Hans de Goede wrote:
> On some x86 Bay Trail tablets which shipped with Android as factory OS,
> the DSDT is so broken that the PMIC needs to be manually instantiated by
> the special x86-android-tablets.ko "fixup" driver for cases like this.
> 
> Add an i2c_device_id table so that the driver can match on manually
> instantiated i2c_client-s (which lack an ACPI fwnode to match on).

...

> +static const struct i2c_device_id crystal_cove_i2c_match[] = {
> +	{ "intel-crystal-cove" },

Why this can't be "crystal_cove_i2c"?

> +	{ }
> +};

...

>  	.driver = {
>  		.name = "crystal_cove_i2c",
>  		.pm = pm_sleep_ptr(&crystal_cove_pm_ops),
>  		.acpi_match_table = crystal_cove_acpi_match,
>  	},

-- 
With Best Regards,
Andy Shevchenko