linux-kernel - Re: [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56c4e49a-b729-4332-b7d2-d8d51edcbd2e@redhat.com>
Date: Sat, 26 Oct 2024 13:42:36 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI
 instantiated i2c_client

Hi Andy,

On 25-Oct-24 3:27 PM, Andy Shevchenko wrote:
> On Fri, Oct 25, 2024 at 10:37:12AM +0200, Hans de Goede wrote:
>> On some x86 Bay Trail tablets which shipped with Android as factory OS,
>> the DSDT is so broken that the PMIC needs to be manually instantiated by
>> the special x86-android-tablets.ko "fixup" driver for cases like this.
>>
>> Add an i2c_device_id table so that the driver can match on manually
>> instantiated i2c_client-s (which lack an ACPI fwnode to match on).
> 
> ...
> 
>> +static const struct i2c_device_id crystal_cove_i2c_match[] = {
>> +	{ "intel-crystal-cove" },
> 
> Why this can't be "crystal_cove_i2c"?

It can be any string as long as it is unique. Typically this will
be vendor-model-name though and having i2c in there is a bit weird
since this is used for the modalias, which gets prefixed with
"i2c:" already.

Therefor I would prefer to keep this as is. But if you have
a strong preference I can change this for v2.

Please let me know how you want to proceed with this patch.

Regards,

Hans



> 
>> +	{ }
>> +};
> 
> ...
> 
>>  	.driver = {
>>  		.name = "crystal_cove_i2c",
>>  		.pm = pm_sleep_ptr(&crystal_cove_pm_ops),
>>  		.acpi_match_table = crystal_cove_acpi_match,
>>  	},
>