linux-kernel - Re: [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the end of structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08cf23fc-a062-418b-aa90-59bc6077f281@gmail.com>
Date: Sat, 26 Oct 2024 09:56:49 +0200
From: Mirsad Todorovac <mtodorovac69@...il.com>
To: Bart Van Assche <bvanassche@....org>, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Nilesh Javali <njavali@...vell.com>,
 GR-QLogic-Storage-Upstream@...vell.com,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the
 end of structures

On 10/24/24 18:55, Bart Van Assche wrote:
> On 10/23/24 9:22 PM, Mirsad Todorovac wrote:
>>  From next-20241023, it seems to have passed compilation:
>>
>>    INSTALL debian/linux-libc-dev/usr/include
>> dpkg-deb: building package 'linux-image-6.12.0-rc4-next-20241023-00001-gdcf82889780d' in '../linux-image-6.12.0-rc4-next-20241023-00001-gdcf82889780d_6.12.0-rc4-00001-gdcf82889780d-4_amd64.deb'.
>> dpkg-deb: building package 'linux-libc-dev' in '../linux-libc-dev_6.12.0-rc4-00001-gdcf82889780d-4_amd64.deb'.
>>   dpkg-genbuildinfo --build=binary -O../linux-upstream_6.12.0-rc4-00001-gdcf82889780d-4_amd64.buildinfo
>>   dpkg-genchanges --build=binary -O../linux-upstream_6.12.0-rc4-00001-gdcf82889780d-4_amd64.changes
>> dpkg-genchanges: info: binary-only upload (no source code included)
>>   dpkg-source --after-build .
>> dpkg-buildpackage: info: binary-only upload (no source included)
> 
> What kernel config is used during that kernel build? Is the qla2xxx
> driver enabled in that kernel config?
> 
> BTW, there is a typo in the subject of your email: gla2xxx should be
> qla2xxx.

You are correct. What a blunder.

> Bart.

Hi,

You were right, of course. There is no config SCSI_QLA_FC nor TCM_QLA2XXX in my .config.

$ grep config drivers/scsi/qla2xxx/Kconfig
config SCSI_QLA_FC
config TCM_QLA2XXX
config TCM_QLA2XXX_DEBUG
$ grep -E '(SCSI_QLA_FC|TCM_QLA2XXX)' .config
$ 

>From what kernel robot produced, it is obvious that this should be done by something with deeper
knowledge of the driver's implementation.

Even when decreasing all those BUG_BUILD_ON() checks would be trivial, there are obviously more
gotchas.

Maybe "make allyesconfig" would spare me from such stupid errors.

But they say that a fail that makes you humble is better than a success that makes you arrogant :-/

Best regards,
Mirsad