linux-kernel - Re: [PATCH][next] um: Malloc just enough space for fitting pid file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxyhbCw39rBzAvtg@mail.google.com>
Date: Sat, 26 Oct 2024 20:59:40 +1300
From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: richard@....at, anton.ivanov@...bridgegreys.com, kees@...nel.org,
	tiwei.btw@...group.com, linux-um@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] um: Malloc just enough space for fitting pid file

On Sat, Oct 26, 2024 at 09:44:53AM +0200, Johannes Berg wrote:

Hi!

> On Sat, 2024-10-26 at 16:46 +1300, Paulo Miguel Almeida wrote:
> > umid is already generated during make_umid_init __initcall so there is
> > no need to allocate UMID_LEN bytes to accommodate the max possible name
> > for the umid segment of the filepath
> > 
> > This patch replaces UMID_LEN occurences in which it's redundant
> 
> OK, I guess that's maybe all true, but can you say _why_ in the commit
> log?
> 
> johannes
> 

thanks for taking the time to review this patch. :-)

when I said that "umid is already generated during make_umid_init
__initcall", from my humble point of view, I was explaining the 'why'
using UMID_LEN for calculation buffer sizes was redundant. Then again,
once we know the size of char* umid, we can use strlen(umid) instead.

I'm happy to amend the commit message to a better one but I'm not
sure if I got 100% what I'm missing.

- Paulo