linux-kernel - Re: [PATCH][next] um: Malloc just enough space for fitting pid file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <433fb0eb0132a583dc5f575f0c99c4adb8ef6cab.camel@sipsolutions.net>
Date: Sat, 26 Oct 2024 10:03:37 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
Cc: richard@....at, anton.ivanov@...bridgegreys.com, kees@...nel.org, 
	tiwei.btw@...group.com, linux-um@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] um: Malloc just enough space for fitting pid file

On Sat, 2024-10-26 at 20:59 +1300, Paulo Miguel Almeida wrote:
> 
> when I said that "umid is already generated during make_umid_init
> __initcall", from my humble point of view, I was explaining the 'why'
> using UMID_LEN for calculation buffer sizes was redundant. Then again,
> once we know the size of char* umid, we can use strlen(umid) instead.

That's not "why am I changing it" though, that's "why does it work".

The only reasonable explanation I could come up with is that you're
trying to save memory ... but why go to the trouble for a function
that's called exactly once?

johannes