[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc1322d4-8312-47a4-929f-086b417d4ae8@oss.qualcomm.com>
Date: Sat, 26 Oct 2024 12:36:10 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Dzmitry Sankouski <dsankouski@...il.com>,
cros-qcom-dts-watchers@...omium.org,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 07/12] arm64: dts: qcom: sdm845-starqltechn: add
max77705 PMIC
On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> Add support for max77705 MFD device. Supported sub-devices:
> charger, fuelgauge, haptic, led
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> ---
[...]
> + vib_regulator: gpio-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "haptic";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + enable-active-high;
> + gpio = <&pm8998_gpios 18 GPIO_ACTIVE_HIGH>;
> + };
Please try to match the property order in the newest DTs, e.g.
vreg_wwan in x1e80100-crd.dts
> +
> + vib_pwm: pwm {
> + compatible = "clk-pwm";
> + #pwm-cells = <2>;
> + assigned-clock-parents = <&rpmhcc RPMH_CXO_CLK>;
Don't you want to set assigned-clock-rates instead?
> + assigned-clocks = <&gcc GCC_GP1_CLK_SRC>;
> + clocks = <&gcc GCC_GP1_CLK>;
> + pinctrl-0 = <&motor_pwm_default_state>;
> + pinctrl-1 = <&motor_pwm_suspend_state>;
> + pinctrl-names = "default", "suspend";
> + };
> };
Looks good otherwise
Konrad
Powered by blists - more mailing lists