[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ac43c69-b3db-4f0f-a562-b8ef7d30530c@oss.qualcomm.com>
Date: Sat, 26 Oct 2024 12:38:29 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Dzmitry Sankouski <dsankouski@...il.com>,
cros-qcom-dts-watchers@...omium.org,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 06/12] arm64: dts: qcom: sdm845-starqltechn: add gpio
keys
On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> Add support for phone buttons.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
>
> ---
> Changes in v6:
> - refactor: s/starqltechn/sdm845-starqltechn in subject.
> ---
> arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> index 5948b401165c..a3bd5231569d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> @@ -7,9 +7,11 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/input/linux-event-codes.h>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sdm845.dtsi"
> +#include "pm8998.dtsi"
>
> / {
> chassis-type = "handset";
> @@ -69,6 +71,25 @@ memory@...00000 {
> pmsg-size = <0x40000>;
> };
> };
> +
> + gpio_keys {
Node names must not contain underscores, use '-' instead
> + compatible = "gpio-keys";
> + autorepeat;
> +
> + key-vol-up {
> + label = "volume_up";
This is passed on to userspace, many DTs use a less programmer-y style,
like "Volume Up"
> + gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + debounce-interval = <15>;
> + };
> +
> + key-wink {
> + label = "key_wink";
What's this key? Bixby?
Konrad
Powered by blists - more mailing lists