linux-kernel - Re: [PATCH v2 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2jrr3stleuals5iadxn6yu5j77wxufavvdqo3e7244ckefrk5@kbvo6fbsref2>
Date: Sat, 26 Oct 2024 14:29:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rouven Czerwinski <r.czerwinski@...gutronix.de>
Cc: Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Sam Ravnborg <sam@...nborg.org>, dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel@...gutronix.de, 
	Neil Armstrong <neil.armstrong@...aro.org>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: display: panel: add YAML schema for
 LXD M9189A

On Fri, Oct 25, 2024 at 04:11:28PM +0200, Rouven Czerwinski wrote:

A nit, subject: drop second/last, redundant "YAML schema for". The
"dt-bindings" prefix is already stating that these are bindings in
schema and YAML.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> +++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LXD M9189A DSI Display Panel
> +
> +maintainers:
> +  - Rouven Czerwinski <r.czerwinski@...gutronix.de>
> +
> +properties:
> +  compatible:
> +    const: lxd,m9189a
> +
> +  reg:
> +    maxItems: 1
> +
> +  standby-gpios:
> +    description: GPIO used for the standby pin
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: GPIO used for the reset pin
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Power regulator
> +
> +  backlight:
> +    description: Backlight used by the panel
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  port: true

This misses it's definition. You should reference proper panel schema in
top-level.

Best regards,
Krzysztof