linux-kernel - Re: [PATCH v2 3/3] drm/panel: add LXD M9189A panel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202411020816.Nb9aEvtO-lkp@intel.com>
Date: Sat, 2 Nov 2024 09:02:53 +0800
From: kernel test robot <lkp@...el.com>
To: Rouven Czerwinski <r.czerwinski@...gutronix.de>,
	Jessica Zhang <quic_jesszhan@...cinc.com>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Cc: oe-kbuild-all@...ts.linux.dev, kernel@...gutronix.de,
	Rouven Czerwinski <r.czerwinski@...gutronix.de>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v2 3/3] drm/panel: add LXD M9189A panel driver

Hi Rouven,

kernel test robot noticed the following build errors:

[auto build test ERROR on c2ee9f594da826bea183ed14f2cc029c719bf4da]

url:    https://github.com/intel-lab-lkp/linux/commits/Rouven-Czerwinski/dt-bindings-display-panel-add-YAML-schema-for-LXD-M9189A/20241025-221252
base:   c2ee9f594da826bea183ed14f2cc029c719bf4da
patch link:    https://lore.kernel.org/r/20241025141130.3179166-3-r.czerwinski%40pengutronix.de
patch subject: [PATCH v2 3/3] drm/panel: add LXD M9189A panel driver
config: arm-randconfig-r062-20241102 (https://download.01.org/0day-ci/archive/20241102/202411020816.Nb9aEvtO-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411020816.Nb9aEvtO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411020816.Nb9aEvtO-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/panel/panel-lxd-m9189a.c:173:29: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
     173 |                 return dev_err_probe(dev, ret, "Failed to get regulator\n");
         |                                           ^~~
   drivers/gpu/drm/panel/panel-lxd-m9189a.c:165:9: note: initialize the variable 'ret' to silence this warning
     165 |         int ret;
         |                ^
         |                 = 0
   1 error generated.


vim +/ret +173 drivers/gpu/drm/panel/panel-lxd-m9189a.c

   160	
   161	static int lxd_m9189_probe(struct mipi_dsi_device *dsi)
   162	{
   163		struct device *dev = &dsi->dev;
   164		struct m9189_panel *m9189;
   165		int ret;
   166	
   167		m9189 = devm_kzalloc(dev, sizeof(*m9189), GFP_KERNEL);
   168		if (!m9189)
   169			return -ENOMEM;
   170	
   171		m9189->supply = devm_regulator_get(dev, "vdd");
   172		if (IS_ERR(m9189->supply))
 > 173			return dev_err_probe(dev, ret, "Failed to get regulator\n");
   174	
   175		m9189->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
   176		if (IS_ERR(m9189->reset_gpio))
   177			return dev_err_probe(dev, PTR_ERR(m9189->reset_gpio),
   178					     "Failed to get reset-gpios\n");
   179	
   180		m9189->standby_gpio = devm_gpiod_get(dev, "standby", GPIOD_OUT_LOW);
   181		if (IS_ERR(m9189->standby_gpio))
   182			return dev_err_probe(dev, PTR_ERR(m9189->standby_gpio),
   183					     "Failed to get standby-gpios\n");
   184	
   185		m9189->dsi = dsi;
   186		mipi_dsi_set_drvdata(dsi, m9189);
   187	
   188		dsi->lanes = 4;
   189		dsi->format = MIPI_DSI_FMT_RGB888;
   190		dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST;
   191	
   192		drm_panel_init(&m9189->panel, dev, &m9189_panel_funcs,
   193			       DRM_MODE_CONNECTOR_DSI);
   194		m9189->panel.prepare_prev_first = true;
   195	
   196		ret = drm_panel_of_backlight(&m9189->panel);
   197		if (ret)
   198			return dev_err_probe(dev, ret, "Failed to get backlight\n");
   199	
   200		drm_panel_add(&m9189->panel);
   201	
   202		ret = mipi_dsi_attach(dsi);
   203		if (ret < 0) {
   204			dev_err_probe(dev, ret, "Failed to attach to DSI host\n");
   205			drm_panel_remove(&m9189->panel);
   206			return ret;
   207		}
   208	
   209		return 0;
   210	}
   211	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki