[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241026133039.10742c75@jic23-huawei>
Date: Sat, 26 Oct 2024 13:30:39 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Julien Stephan <jstephan@...libre.com>
Cc: Mudit Sharma <muditsharma.info@...il.com>, Lars-Peter Clausen
<lars@...afoo.de>, Anshul Dalal <anshulusr@...il.com>, Javier Carrasco
<javier.carrasco.cruz@...il.com>, Jean-Baptiste Maneyrol
<jean-baptiste.maneyrol@....com>, Michael Hennerich
<Michael.Hennerich@...log.com>, Cosmin Tanislav
<cosmin.tanislav@...log.com>, Ramona Gradinariu
<ramona.gradinariu@...log.com>, Antoniu Miclaus
<antoniu.miclaus@...log.com>, Dan Robertson <dan@...obertson.com>, Marcelo
Schmitt <marcelo.schmitt@...log.com>, Matteo Martelli
<matteomartelli3@...il.com>, Anand Ashok Dumbre
<anand.ashok.dumbre@...inx.com>, Michal Simek <michal.simek@....com>,
Mariel Tinaco <Mariel.Tinaco@...log.com>, Jagath Jog J
<jagathjog1996@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Subhajit
Ghosh <subhajit.ghosh@...aklogic.com>, Kevin Tsai <ktsai@...ellamicro.com>,
Linus Walleij <linus.walleij@...aro.org>, Benson Leung
<bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev
Subject: Re: [PATCH 6/7] iio: light: stk3310: simplify code in
write_event_config callback
On Thu, 24 Oct 2024 11:11:28 +0200
Julien Stephan <jstephan@...libre.com> wrote:
> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@...libre.com>
This one is odd. The field is 1 bit so I've no idea why checking against 7
would ever have made sense.
Applied, but if anyone is familiar with this part I would like more
eyes on that code to see if there is a bug hiding there.
Jonathan
> ---
> drivers/iio/light/stk3310.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> index ed20b67145463d253a0dff28a4c1c3e02e710319..c6f950af5afa0f77a617bd2baf0a08eef5ec26f0 100644
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -330,9 +330,6 @@ static int stk3310_write_event_config(struct iio_dev *indio_dev,
> struct stk3310_data *data = iio_priv(indio_dev);
> struct i2c_client *client = data->client;
>
> - if (state < 0 || state > 7)
> - return -EINVAL;
> -
> /* Set INT_PS value */
> mutex_lock(&data->lock);
> ret = regmap_field_write(data->reg_int_ps, state);
>
Powered by blists - more mailing lists