linux-kernel - Re: [PATCH v2 00/10] Enhance min heap API with non-inline functions and optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxzkLJmhn3a/1ALQ@visitorckw-System-Product-Name>
Date: Sat, 26 Oct 2024 20:44:28 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: kent.overstreet@...ux.dev
Cc: mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, willy@...radead.org,
	jserv@...s.ncku.edu.tw, linux-kernel@...r.kernel.org,
	linux-bcache@...r.kernel.org, dm-devel@...ts.linux.dev,
	linux-bcachefs@...r.kernel.org, linux-perf-users@...r.kernel.org,
	linux-doc@...r.kernel.org, colyli@...e.de, msakai@...hat.com,
	corbet@....net, peterz@...radead.org, mingo@...hat.com,
	acme@...nel.org, namhyung@...nel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH v2 00/10] Enhance min heap API with non-inline functions
 and optimizations

On Sun, Oct 20, 2024 at 12:01:50PM +0800, Kuan-Wei Chiu wrote:
> Add non-inline versions of the min heap API functions in lib/min_heap.c
> and updates all users outside of kernel/events/core.c to use these
> non-inline versions. To mitigate the performance impact of indirect
> function calls caused by the non-inline versions of the swap and
> compare functions, a builtin swap has been introduced that swaps
> elements based on their size. Additionally, it micro-optimizes the
> efficiency of the min heap by pre-scaling the counter, following the
> same approach as in lib/sort.c. Documentation for the min heap API has
> also been added to the core-api section.
>
Hi Kent,

FWIW, here are the bcachefs CI test results for this patch series:
https://evilpiepirate.org/~testdashboard/ci?user=visitorckw&branch=min-heap-update

Regards,
Kuan-Wei