linux-kernel - Re: [PATCH] goldfish: Fix unused const variable 'goldfish_pipe_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42b52500-9243-432e-1359-086012a60e81@huawei.com>
Date: Sat, 26 Oct 2024 09:28:11 +0800
From: Zeng Heng <zengheng4@...wei.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: <jia-cheng.hu@...el.com>, <gregkh@...uxfoundation.org>,
	<quic_jjohnson@...cinc.com>, <jinqian@...roid.com>, <alan@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>, <bobo.shaobowang@...wei.com>
Subject: Re: [PATCH] goldfish: Fix unused const variable
 'goldfish_pipe_acpi_match'


On 2024/10/25 22:27, Uwe Kleine-König wrote:
> Hello,
>
> [Cc += Andy]

I would loop in the next version.


>
> On Fri, Oct 25, 2024 at 03:41:29PM +0800, Zeng Heng wrote:
>> Fix the following compilation warning:
>>
>> drivers/platform/goldfish/goldfish_pipe.c:925:36: warning:
>> ‘goldfish_pipe_acpi_match’ defined but not used
>> [-Wunused-const-variable=]
>>    925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
>>
>> Only define the const variable when the CONFIG_ACPI is enabled.
> Note you also need CONFIG_MODULE=n to reproduce.
>
>> Fixes: d62f324b0ac8 ("goldfish: Enable ACPI-based enumeration for android pipe")
>> Signed-off-by: Zeng Heng <zengheng4@...wei.com>
>> ---
>>   drivers/platform/goldfish/goldfish_pipe.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
>> index c2aab0cfab33..aeabacba3760 100644
>> --- a/drivers/platform/goldfish/goldfish_pipe.c
>> +++ b/drivers/platform/goldfish/goldfish_pipe.c
>> @@ -922,11 +922,13 @@ static void goldfish_pipe_remove(struct platform_device *pdev)
>>   	goldfish_pipe_device_deinit(pdev, dev);
>>   }
>>   
>> +#ifdef CONFIG_ACPI
>>   static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
>>   	{ "GFSH0003", 0 },
>>   	{ },
>>   };
>>   MODULE_DEVICE_TABLE(acpi, goldfish_pipe_acpi_match);
>> +#endif
>>   
>>   static const struct of_device_id goldfish_pipe_of_match[] = {
>>   	{ .compatible = "google,android-pipe", },
> Looking at changes like
> https://lore.kernel.org/all/20241024130424.3818291-11-andriy.shevchenko@linux.intel.com/
> I suggest to drop the use of ACPI_PTR() instead.

Right, got it.


Best regards,

Zeng Heng