linux-kernel - Re: [PATCH] goldfish: Fix unused const variable 'goldfish_pipe_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zxur7RC-bBYX79WJ@smile.fi.intel.com>
Date: Fri, 25 Oct 2024 17:32:13 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Zeng Heng <zengheng4@...wei.com>, jia-cheng.hu@...el.com,
	gregkh@...uxfoundation.org, quic_jjohnson@...cinc.com,
	jinqian@...roid.com, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org, bobo.shaobowang@...wei.com
Subject: Re: [PATCH] goldfish: Fix unused const variable
 'goldfish_pipe_acpi_match'

On Fri, Oct 25, 2024 at 04:27:07PM +0200, Uwe Kleine-König wrote:
> On Fri, Oct 25, 2024 at 03:41:29PM +0800, Zeng Heng wrote:
> > Fix the following compilation warning:
> > 
> > drivers/platform/goldfish/goldfish_pipe.c:925:36: warning:
> > ‘goldfish_pipe_acpi_match’ defined but not used
> > [-Wunused-const-variable=]
> >   925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
> > 
> > Only define the const variable when the CONFIG_ACPI is enabled.

...

> Looking at changes like
> https://lore.kernel.org/all/20241024130424.3818291-11-andriy.shevchenko@linux.intel.com/
> I suggest to drop the use of ACPI_PTR() instead.

Right, please drop ACPI_PTR() and if needed, replace acpi.h with proper
mod_devicetable.h. You may find tons of examples in IIO:
`git log --grep ACPI_PTR -- drivers/iio`.

P.S. Thanks for Cc'ing me!

-- 
With Best Regards,
Andy Shevchenko