linux-kernel - Re: [PATCH v2] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91a8d0ab-a6a6-4dfa-8613-8d4dbafeda40@kernel.org>
Date: Sat, 26 Oct 2024 20:06:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tarang Raval <tarang.raval@...iconsignals.io>,
 Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
Cc: "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to
 yaml format

On 26/10/2024 17:02, Tarang Raval wrote:
> Hi Krzysztof , Himanshu
> 
>>>> +
>>>> +    i2c {
>>>
>>> Keep one complete example for i2c and one for spi. This was not in
>>> previous patch and change log does not explain why you need three
>>> examples.
>>
>> Okay, I will drop one example of I2C
> 
> In ex1: use when you only need basic GPIO and interrupt capabilities 
> without additional pin control and in ex2: use when you need pull-up 
> resistors on specific GPIO pins or a reset line.
> 
> Original bindings state that this node can be implemented in two 
> different ways, so we should maintain both examples for reference.

Example is not the binding. If you claim conversion is incomplete, it
must be done through the binding, not example.

> 
> But it's up to you, I trust your expertise on this, Krzysztof
> 
>>>> +        #address-cells = <1>;
>>>> +        #size-cells = <0>;
>>>> +
>>>> +        mcp23017: gpio@21 {
>>>
>>> Drop unused label
>>  
>> May I know how its unused, AFAIK, Since it's an I/O expanded, it’s referenced elsewhere, so keeping it is necessary for >functionality.
> 
> I agree with Himanshu. 
> It's definitely used for reset GPIOs, LED pins, or something similar.

So point to the specific line in this file. Really, it's no different
than every other binding. If it is different, provide some arguments why
this is different.

Best regards,
Krzysztof