linux-kernel - Re: [PATCH v3 2/2] iio: light: add support for veml3235

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241026191001.10acd773@jic23-huawei>
Date: Sat, 26 Oct 2024 19:10:01 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: kernel test robot <lkp@...el.com>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Rishi Gupta <gupt21@...il.com>,
 oe-kbuild-all@...ts.linux.dev, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] iio: light: add support for veml3235

Hi Javier,

> >    222	
> >    223		return 0;
> >    224	}
> >    225	
> >   
> 
> 
> Unused as there is no processed values anymore. I will drop them for v4.
Given I didn't have any other comments I just fixed these up whilst applying.

Series applied to the togreg branch of iio.git and initially pushed out as
testing for 0-day to take a first look at it.
Thanks,

Jonathan

p.s. Diff was as follows, shout if I mess it up.

diff --git a/drivers/iio/light/veml3235.c b/drivers/iio/light/veml3235.c
index 18ab73f4377c..66361c3012a3 100644
--- a/drivers/iio/light/veml3235.c
+++ b/drivers/iio/light/veml3235.c
@@ -145,7 +145,7 @@ static int veml3235_get_it(struct veml3235_data *data, int *val, int *val2)
 static int veml3235_set_it(struct iio_dev *indio_dev, int val, int val2)
 {
        struct veml3235_data *data = iio_priv(indio_dev);
-       int ret, new_it, it_idx;
+       int ret, new_it;
 
        if (val)
                return -EINVAL;
@@ -153,23 +153,18 @@ static int veml3235_set_it(struct iio_dev *indio_dev, int val, int val2)
        switch (val2) {
        case 50000:
                new_it = 0x00;
-               it_idx = 4;
                break;
        case 100000:
                new_it = 0x01;
-               it_idx = 3;
                break;
        case 200000:
                new_it = 0x02;
-               it_idx = 2;
                break;
        case 400000:
                new_it = 0x03;
-               it_idx = 1;
                break;
        case 800000:
                new_it = 0x04;
-               it_idx = 0;
                break;
        default:
                return -EINVAL;
@@ -188,7 +183,7 @@ static int veml3235_set_it(struct iio_dev *indio_dev, int val, int val2)
 static int veml3235_set_gain(struct iio_dev *indio_dev, int val, int val2)
 {
        struct veml3235_data *data = iio_priv(indio_dev);
-       int ret, new_gain, gain_idx;
+       int ret, new_gain;
 
        if (val2 != 0)
                return -EINVAL;
@@ -196,19 +191,15 @@ static int veml3235_set_gain(struct iio_dev *indio_dev, int val, int val2)
        switch (val) {
        case 1:
                new_gain = 0x00;
-               gain_idx = 3;
                break;
        case 2:
                new_gain = 0x01;
-               gain_idx = 2;
                break;
        case 4:
                new_gain = 0x03;
-               gain_idx = 1;
                break;
        case 8:
                new_gain = 0x07;
-               gain_idx = 0;
                break;
        default:
                return -EINVAL;


>