linux-kernel - Re: [PATCH v2 02/13] iio: chemical: bme680: optimize startup time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241027095335.1fdd4cdf@jic23-huawei>
Date: Sun, 27 Oct 2024 09:53:35 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
 anshulusr@...il.com, gustavograzs@...il.com, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/13] iio: chemical: bme680: optimize startup time

On Mon, 21 Oct 2024 21:53:05 +0200
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> According to datasheet's Section 1.1, Table 1, the startup time for the
> device is 2ms and not 5ms.
Ok.  If this were just in the probe path  (which it is today)
I would not bother with the risk for a 3msec potential saving.
However, you are going to reuse it in runtime resume where the effects
will be more obvious. 

Hence applied to the togreg branch of iio.git and pushed out as testing.
*fingers crossed* no one has out of spec wiring that needs a little longer
than the spec says.

Jonathan

> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> ---
>  drivers/iio/chemical/bme680.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h
> index dc9ff477da34..f5be4516dde7 100644
> --- a/drivers/iio/chemical/bme680.h
> +++ b/drivers/iio/chemical/bme680.h
> @@ -65,7 +65,8 @@
>  
>  #define BME680_MEAS_TRIM_MASK			GENMASK(24, 4)
>  
> -#define BME680_STARTUP_TIME_US			5000
> +/* Datasheet Section 1.1, Table 1 */
> +#define BME680_STARTUP_TIME_US			2000
>  
>  /* Calibration Parameters */
>  #define BME680_T2_LSB_REG	0x8A