linux-kernel - Re: [PATCH v8 2/3] tpm: Rollback tpm2_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D57G47THRYCG.217GTO2ZF5333@kernel.org>
Date: Mon, 28 Oct 2024 14:42:10 +0200
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Paul Menzel" <pmenzel@...gen.mpg.de>,
 <linux-integrity@...r.kernel.org>, "Peter Huewe" <peterhuewe@....de>,
 "Jason Gunthorpe" <jgg@...pe.ca>, "James Bottomley"
 <James.Bottomley@...senPartnership.com>
Cc: <linux-kernel@...r.kernel.org>, "David Howells" <dhowells@...hat.com>,
 "Mimi Zohar" <zohar@...ux.ibm.com>, "Roberto Sassu"
 <roberto.sassu@...wei.com>, "Stefan Berger" <stefanb@...ux.ibm.com>, "Paul
 Moore" <paul@...l-moore.com>, "James Morris" <jmorris@...ei.org>, "Serge E.
 Hallyn" <serge@...lyn.com>, "Dmitry Kasatkin" <dmitry.kasatkin@...il.com>,
 "Eric Snowberg" <eric.snowberg@...cle.com>, <keyrings@...r.kernel.org>,
 <linux-security-module@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH v8 2/3] tpm: Rollback tpm2_load_null()

On Mon Oct 28, 2024 at 2:38 PM EET, Paul Menzel wrote:
> Dear Jarkko,
>
>
> Am 28.10.24 um 13:10 schrieb Jarkko Sakkinen:
> > On Mon Oct 28, 2024 at 8:13 AM EET, Paul Menzel wrote:
>
> >> Am 28.10.24 um 06:50 schrieb Jarkko Sakkinen:
> >>> Do not continue on tpm2_create_primary() failure in tpm2_load_null().
> >>
> >> Could you please elaborate, why this is done, that means the motivation
> >> for your change?
> > 
> > Which part of "not properly handling a return value" I should explain?
>
> Sorry, where is your quote from?
>
> Anyway, maybe explaining why a successful call to tpm2_create_primary() 
> is needed to continue would at least help me.

It's not a void function.

BR, Jarkko