linux-kernel - Re: [RFC PATCH v4 2/4] tracing: Introduce tracepoint_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89947c86-a8fa-425f-8e86-d80bb5220280@efficios.com>
Date: Mon, 28 Oct 2024 16:24:32 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
 Thomas Gleixner <tglx@...utronix.de>, Michael Jeanson
 <mjeanson@...icios.com>, Masami Hiramatsu <mhiramat@...nel.org>,
 Peter Zijlstra <peterz@...radead.org>, Alexei Starovoitov <ast@...nel.org>,
 Yonghong Song <yhs@...com>, "Paul E . McKenney" <paulmck@...nel.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Namhyung Kim <namhyung@...nel.org>, bpf@...r.kernel.org,
 Joel Fernandes <joel@...lfernandes.org>, Jordan Rife <jrife@...gle.com>
Subject: Re: [RFC PATCH v4 2/4] tracing: Introduce tracepoint_is_faultable()

On 2024-10-28 16:19, Andrii Nakryiko wrote:
> On Mon, Oct 28, 2024 at 12:11 PM Mathieu Desnoyers
> <mathieu.desnoyers@...icios.com> wrote:
>>
>> Introduce a "faultable" flag within the extended structure to know
>> whether a tracepoint needs rcu tasks trace grace period before reclaim.
>> This can be queried using tracepoint_is_faultable().
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> Cc: Michael Jeanson <mjeanson@...icios.com>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Masami Hiramatsu <mhiramat@...nel.org>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Alexei Starovoitov <ast@...nel.org>
>> Cc: Yonghong Song <yhs@...com>
>> Cc: Paul E. McKenney <paulmck@...nel.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Andrii Nakryiko <andrii.nakryiko@...il.com>
>> Cc: bpf@...r.kernel.org
>> Cc: Joel Fernandes <joel@...lfernandes.org>
>> Cc: Jordan Rife <jrife@...gle.com>
>> ---
>>   include/linux/tracepoint-defs.h |  2 ++
>>   include/linux/tracepoint.h      | 24 ++++++++++++++++++++++++
>>   include/trace/define_trace.h    |  2 +-
>>   3 files changed, 27 insertions(+), 1 deletion(-)
>>
> 
> LGTM

FYI I'm still missing the "static" here:

>> +#define DEFINE_TRACE_SYSCALL(_name, _reg, _unreg, _proto, _args)       \
>> +       struct tracepoint_ext __tracepoint_ext_##_name = {              \
>> +               .regfunc = _reg,                                        \
>> +               .unregfunc = _unreg,                                    \
>> +               .faultable = true,                                      \
>>          };      

Will fix in v5.

Acked-by noted, thanks!

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com