linux-kernel - Re: [PATCH v6 03/10] x86/virt/tdx: Use auto-generated code to read global metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554e098b-f640-4dda-a829-5bcd3f6ea2e2@intel.com>
Date: Tue, 29 Oct 2024 11:47:46 +1300
From: "Huang, Kai" <kai.huang@...el.com>
To: Dan Williams <dan.j.williams@...el.com>, <dave.hansen@...el.com>,
	<kirill.shutemov@...ux.intel.com>, <tglx@...utronix.de>, <bp@...en8.de>,
	<peterz@...radead.org>, <mingo@...hat.com>, <hpa@...or.com>,
	<seanjc@...gle.com>, <pbonzini@...hat.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
	<rick.p.edgecombe@...el.com>, <isaku.yamahata@...el.com>,
	<adrian.hunter@...el.com>, <nik.borisov@...e.com>
Subject: Re: [PATCH v6 03/10] x86/virt/tdx: Use auto-generated code to read
 global metadata


>>    1) Using the generated C is simple.
>>    2) Adding a field is dirty simple, e.g., the script just pulls the
> 
> Probably meant "dirt simple", but if this is fixed up on apply I'd drop
> the idiom and just say "simple".

Yeah "dirt simple".  I missed this.  Will just say "simple" if a new 
version is needed.

[...]

>>
>> Link: https://lore.kernel.org/lkml/4b3adb59-50ea-419e-ad02-e19e8ca20dee@intel.com/ [1]
>> Link: https://lore.kernel.org/all/fc0e8ab7-86d4-4428-be31-82e1ece6dd21@intel.com/ [2]
>> Link: https://lore.kernel.org/kvm/0853b155ec9aac09c594caa60914ed6ea4dc0a71.camel@intel.com/ [5]
> 
> Just an fyi, that lore accepts the simple:
> 
> https://lore.kernel.org/$msg_id
> 
> ...format, no need to record the list name in the URL (127734e23aed
> ("Documentation: best practices for using Link trailers"))

Thanks for the info.  I got those link by clicking the "permalink" on 
the webpage, and then I just paste.

Yeah "https://lore.kernel.org/$msg_id" works, but if I open the page 
using this format the like is changed to:

   "https://lore.kernel.org/all/$msg_id"

So I thought I just don't bother to remove the "all/lkml/kvm" in the 
link.  I'll change to use the simple format in the future since it is 
said in the Documentation.

> 
>> Link: https://github.com/canonical/tdx/issues/135 [3]
>> Link: https://cdrdv2.intel.com/v1/dl/getContent/795381 [4]
>> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
>> Co-developed-by: Kai Huang <kai.huang@...el.com>
>> Signed-off-by: Kai Huang <kai.huang@...el.com>
> 
> Looks good to me, with or without the above nits addressed.
> 
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>

Thanks.  I'll fixup if a new version is needed.