linux-kernel - Re: [PATCH] scsi: pm80xx: Use module param to set pcs event log severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPE3x14n16PX=pkLVJ2x2T3VZYKfbLUk94wd5_5S9WDCSpmQ3Q@mail.gmail.com>
Date: Mon, 28 Oct 2024 16:57:28 -0700
From: Salomon Dushimirimana <salomondush@...gle.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Jinpu Wang <jinpu.wang@...os.com>, Jack Wang <jinpu.wang@...ud.ionos.com>, 
	"James E . J . Bottomley" <James.Bottomley@...senpartnership.com>, linux-scsi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Bhavesh Jashnani <bjashnani@...gle.com>
Subject: Re: [PATCH] scsi: pm80xx: Use module param to set pcs event log severity

Hi,

These are the log levels and their descriptions for the pm80xx controllers -
0 - Disable logging
1 - Critical error
2 - Warning
3 - Notice
4 - Information
5 - Debugging
6 - Reserved

Loglevel 3 helps capture messages of severity level 3 and above. It is
not expected to be verbose and helps avoid the log overflow problem.

For debugging, there may be a need to change the loglevel, hence
making it configurable.

Thanks,
Salomon Dushimirimana

Salomon Dushimirimana


On Fri, Oct 25, 2024 at 11:45 AM Martin K. Petersen
<martin.petersen@...cle.com> wrote:
>
>
> Salomon,
>
> > 3 works well for Google, but a different value might be better for
> > others. Having a module parameter would allow users to customize the
> > level of logging based on their specific needs. If that is not a
> > concern, I can change the default to just 3.
>
> How verbose will a value of 3 be during normal operation? I don't object
> to capturing more information during failure scenarios as long as we're
> not flooding the logs with noise when things are nominal.
>
> --
> Martin K. Petersen      Oracle Linux Engineering