linux-kernel - Re: [PATCH v8 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5862062c-8c52-421d-94b3-6b6000b53616@quicinc.com>
Date: Mon, 28 Oct 2024 13:15:40 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <andersson@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <konradybcio@...nel.org>, <catalin.marinas@....com>, <will@...nel.org>,
        <p.zabel@...gutronix.de>, <richardcochran@...il.com>,
        <geert+renesas@...der.be>, <dmitry.baryshkov@...aro.org>,
        <angelogioacchino.delregno@...labora.com>, <neil.armstrong@...aro.org>,
        <arnd@...db.de>, <nfraprado@...labora.com>, <quic_anusha@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v8 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and
 reset definitions



On 10/25/2024 5:30 PM, Krzysztof Kozlowski wrote:
> On Fri, Oct 25, 2024 at 09:25:17AM +0530, Manikanta Mylavarapu wrote:
>> From: Devi Priya <quic_devipriy@...cinc.com>
>>
>> Add NSSCC clock and reset definitions for ipq9574.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>> Changes in V8:
>> 	- Replace bias_pll_cc_clk, bias_pll_ubi_nc_clk with CMN_PLL
>> 	  NSS_1200MHZ_CLK and PPE_353MHZ_CLK
>> 	- Remove bias_pll_nss_noc_clk because it's not required.
>> 	- Drop R-b tag
> 
> That's not really a change waranting re-review.
> 
> I wished you did not create here dependency, skipped the header and just
> use some number for the clock. Having dependencies does not help anyone:
> neither you to get this merged, nor us to see that it was tested.
> 
> Please confirm that this patch was fully tested.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
> 
> 

Yes, it's fully tested.

Thanks & Regards,
Manikanta.