linux-kernel - Re: [PATCH 24/31] tracing/osnoise: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241028035232.0981c3ed@rorschach.local.home>
Date: Mon, 28 Oct 2024 03:52:32 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Nam Cao <namcao@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Andreas
 Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Miguel
 Ojeda <ojeda@...nel.org>, Kees Cook <kees@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 24/31] tracing/osnoise: Switch to use hrtimer_setup()

On Mon, 28 Oct 2024 08:31:57 +0100
Nam Cao <namcao@...utronix.de> wrote:

> There is a newly introduced hrtimer_setup() which will replace
> hrtimer_init(). This new function is similar to the old one, except that it
> also sanity-checks and initializes the timer's callback function.
> 
> Switch to use this new function.
> 
> Patch was created by using Coccinelle.
> 

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> Signed-off-by: Nam Cao <namcao@...utronix.de>
> ---
> Cc: Steven Rostedt <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_osnoise.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
> index 1439064f65d6..e50f7a1aae6d 100644
> --- a/kernel/trace/trace_osnoise.c
> +++ b/kernel/trace/trace_osnoise.c
> @@ -1896,8 +1896,7 @@ static int timerlat_main(void *data)
>  	tlat->count = 0;
>  	tlat->tracing_thread = false;
>  
> -	hrtimer_init(&tlat->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
> -	tlat->timer.function = timerlat_irq;
> +	hrtimer_setup(&tlat->timer, timerlat_irq, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
>  	tlat->kthread = current;
>  	osn_var->pid = current->pid;
>  	/*
> @@ -2461,8 +2460,7 @@ static int timerlat_fd_open(struct inode *inode, struct file *file)
>  	tlat = this_cpu_tmr_var();
>  	tlat->count = 0;
>  
> -	hrtimer_init(&tlat->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
> -	tlat->timer.function = timerlat_irq;
> +	hrtimer_setup(&tlat->timer, timerlat_irq, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
>  
>  	migrate_enable();
>  	return 0;