linux-kernel - Re: [PATCH 05/31] KVM: arm64: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87msiots1g.wl-maz@kernel.org>
Date: Mon, 28 Oct 2024 10:56:11 +0000
From: Marc Zyngier <maz@...nel.org>
To: Nam Cao <namcao@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Kees Cook <kees@...nel.org>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Joey Gouly <joey.gouly@....com>,
	Oliver Upton <oliver.upton@...ux.dev>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/31] KVM: arm64: Switch to use hrtimer_setup()

[+ the rest of the KVM/arm64 maintainers/reviewers]

On Mon, 28 Oct 2024 07:31:38 +0000,
Nam Cao <namcao@...utronix.de> wrote:
> 
> There is a newly introduced hrtimer_setup() which will replace
> hrtimer_init(). This new function is similar to the old one, except that it
> also sanity-checks and initializes the timer's callback function.
> 
> Switch to use this new function.
> 
> Signed-off-by: Nam Cao <namcao@...utronix.de>
> ---
> Cc: Marc Zyngier <maz@...nel.org>
> ---
>  arch/arm64/kvm/arch_timer.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c
> index 879982b1cc73..92e4fb5dcf52 100644
> --- a/arch/arm64/kvm/arch_timer.c
> +++ b/arch/arm64/kvm/arch_timer.c
> @@ -993,8 +993,7 @@ static void timer_context_init(struct kvm_vcpu *vcpu, int timerid)
>  	else
>  		ctxt->offset.vm_offset = &kvm->arch.timer_data.poffset;
>  
> -	hrtimer_init(&ctxt->hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD);
> -	ctxt->hrtimer.function = kvm_hrtimer_expire;
> +	hrtimer_setup(&ctxt->hrtimer, kvm_hrtimer_expire, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD);
>  
>  	switch (timerid) {
>  	case TIMER_PTIMER:
> @@ -1021,8 +1020,8 @@ void kvm_timer_vcpu_init(struct kvm_vcpu *vcpu)
>  		timer_set_offset(vcpu_ptimer(vcpu), 0);
>  	}
>  
> -	hrtimer_init(&timer->bg_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD);
> -	timer->bg_timer.function = kvm_bg_timer_expire;
> +	hrtimer_setup(&timer->bg_timer, kvm_bg_timer_expire, CLOCK_MONOTONIC,
> +		      HRTIMER_MODE_ABS_HARD);
>  }
>  
>  void kvm_timer_init_vm(struct kvm *kvm)


Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.