linux-kernel - RE: [PATCH v5 11/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CYYPR12MB86550A940AFAA3FE846D7CCE9C4A2@CYYPR12MB8655.namprd12.prod.outlook.com>
Date: Mon, 28 Oct 2024 07:56:47 +0000
From: "Yuan, Perry" <Perry.Yuan@....com>
To: "Limonciello, Mario" <Mario.Limonciello@....com>, Borislav Petkov
	<bp@...en8.de>, Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: "x86@...nel.org" <x86@...nel.org>, "Shenoy, Gautham Ranjal"
	<gautham.shenoy@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>, "platform-driver-x86@...r.kernel.org"
	<platform-driver-x86@...r.kernel.org>, "S-k, Shyam-sundar"
	<Shyam-sundar.S-k@....com>
Subject: RE: [PATCH v5 11/13] cpufreq/amd-pstate: Disable preferred cores on
 designs with workload classification

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@....com>
> Sent: Monday, October 28, 2024 10:03 AM
> To: Borislav Petkov <bp@...en8.de>; Hans de Goede <hdegoede@...hat.com>;
> Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Cc: x86@...nel.org; Shenoy, Gautham Ranjal <gautham.shenoy@....com>;
> Limonciello, Mario <Mario.Limonciello@....com>; Yuan, Perry
> <Perry.Yuan@....com>; linux-kernel@...r.kernel.org; linux-doc@...r.kernel.org;
> linux-pm@...r.kernel.org; platform-driver-x86@...r.kernel.org; S-k, Shyam-
> sundar <Shyam-sundar.S-k@....com>
> Subject: [PATCH v5 11/13] cpufreq/amd-pstate: Disable preferred cores on designs
> with workload classification
>
> On designs that have workload classification, it's preferred that the amd-hfi driver is
> used to provide hints to the scheduler of which cores to use instead of the amd-
> pstate driver.
>
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/cpufreq/amd-pstate.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
> 32ddbf37a9f0a..c60cc84866982 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -780,6 +780,12 @@ static void amd_pstate_init_prefcore(struct amd_cpudata
> *cpudata)
>       /* user disabled or not detected */
>       if (!amd_pstate_prefcore)
>               return;
> +     /* should use amd-hfi instead */
> +     if (boot_cpu_has(X86_FEATURE_AMD_WORKLOAD_CLASS) &&
> +         IS_ENABLED(CONFIG_AMD_HFI)) {
> +             amd_pstate_prefcore = false;
> +             return;
> +     }
>
>       cpudata->hw_prefcore = true;
>
> --
> 2.43.0

LGTM, the legacy prefer core need to be disabled when HFI loaded.

Reviewed-by: Perry Yuan <perry.yuan@....com>