linux-kernel - Re: [PATCH v3 02/10] dma-engine: sun4i: Add has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <748346c6-56e0-4d70-b86b-edd75c8060ed@kernel.org>
Date: Mon, 28 Oct 2024 09:11:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Mesih Kilinc <mesihkilinc@...il.com>, Vinod Koul <vkoul@...nel.org>,
 Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v3 02/10] dma-engine: sun4i: Add has_reset option to quirk

On 28/10/2024 08:31, Csókás Bence wrote:
> Hi,
> 
> On 2024. 10. 27. 21:43, Krzysztof Kozlowski wrote:
>> You did not build v2. Then you send v3... which you also did not build.
>>
>> Please start at least compiling your own code. Then start testing it,
>> but without building it cannot obviously be even tested.
> 
> I forgot to rebase an amend! before sending v2, which I corrected in v3. 
> I *did* in fact build v3 (after the aforementioned correction) rebased 
> on top of Linux 6.5, which is what I have available for my board. And I 

We cannot take patches based on v6.5. That's some close to ancient
kernel nowadays.

> also *did* test with aplay and confirmed to have working audio. If you 
> believe there are differences between 6.5 and master that break v3 of 

Yes, there are thousands of changes with possible impact.

All your patches must be prepared on latest mainline tree. All your SoC
code must be tested on *latest mainline tree*.

> the patch, then please point those out as opposed to making accusations.

First, your code does not build. Your code might not even apply. I do
not have to point patches causing it, because your job is to work on
mainline. But if you ask about patches causing issues, then I also do
not have to go through 50 000 commits which could have possible impact,
because you are supposed to work on mainline kernel.

Best regards,
Krzysztof