[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5fa06b0c-a420-41a4-97ce-b6e5055ab397@kernel.org>
Date: Mon, 28 Oct 2024 09:08:33 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
Mesih Kilinc <mesihkilinc@...il.com>, Vinod Koul <vkoul@...nel.org>,
Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>, Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v2 02/10] dma-engine: sun4i: Add has_reset option to quirk
On 28/10/2024 08:37, Csókás Bence wrote:
> Hi,
>
> On 2024. 10. 27. 21:42, Krzysztof Kozlowski wrote:
>> On Sun, Oct 27, 2024 at 10:14:32AM +0100, Csókás, Bence wrote:
>>> From: Mesih Kilinc <mesihkilinc@...il.com>
>>>
>>> Allwinner suniv F1C100s has a reset bit for DMA in CCU. Sun4i do not
>>> has this bit but in order to support suniv we need to add it. So add
>>> support for reset bit.
>>>
>>> static struct sun4i_dma_dev *to_sun4i_dma_dev(struct dma_device *dev)
>>> @@ -1215,6 +1218,15 @@ static int sun4i_dma_probe(struct platform_device *pdev)
>>> return PTR_ERR(priv->clk);
>>> }
>>>
>>> + if (priv->cfg->has_reset) {
>>> + priv->rst = devm_reset_control_get_exclusive(&pdev->dev,
>>> + NULL);
>>> + if (IS_ERR(priv->rst)) {
>>> + dev_err_probe(&pdev->dev, "Failed to get reset control\n");
>>
>> syntax is: return dev_err_probe()
>>
>> Best regards,
>> Krzysztof
>
> Thanks! And regarding v3 of this patch, I have `clk_disable_unprepare()`
No, you do not. Read your code correctly.
+ dev_err_probe(&pdev->dev, "Failed to get reset control\n");
+ return PTR_ERR(priv->rst);
Where is here clk_disable_unprepare()?
Best regards,
Krzysztof
Powered by blists - more mailing lists