lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zx9eHz2yMMN5UFz4@smile.fi.intel.com>
Date: Mon, 28 Oct 2024 11:49:19 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Marius Cristea <marius.cristea@...rochip.com>,
	Trevor Gamblin <tgamblin@...libre.com>,
	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>,
	Hans de Goede <hdegoede@...hat.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v3 12/24] iio: accel: kxcjk-1013: Move odr_start_up_times
 up in the code

On Sat, Oct 26, 2024 at 12:30:12PM +0100, Jonathan Cameron wrote:
> On Thu, 24 Oct 2024 22:05:01 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

...

> > While at it, make it clear what values from enum are being used for
> > the respective array entries.
> I did some cheeky white space additions in this one as well.
> Bit naughty in a code move patch, but I really want to get this
> stuff cleaned up across IIO and it seems silly to chase your series
> with another one changing the same code.

I like you change, thanks!

...

> > +		{0, 80000},
> I changed this to
> 		{ 0x00, 80000 }
> as I think it helps readability to have them
> all aligned
> 
> Spaces added to all entries.

Got it, please also add/fold the patch I sent today.

-- 
With Best Regards,
Andy Shevchenko



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ