linux-kernel - RE: [PATCH] drm/xe/hdcp: Fix logic errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN7PR11MB6750A49CB7F7EB13F8BE0A96E34A2@SN7PR11MB6750.namprd11.prod.outlook.com>
Date: Mon, 28 Oct 2024 11:50:11 +0000
From: "Kandpal, Suraj" <suraj.kandpal@...el.com>
To: "1064094935@...com" <1064094935@...com>, Jani Nikula
	<jani.nikula@...ux.intel.com>
CC: "Vivi, Rodrigo" <rodrigo.vivi@...el.com>, "De Marchi, Lucas"
	<lucas.demarchi@...el.com>, Thomas <thomas.hellstrom@...ux.intel.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	"intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, pengfuyuan
	<pengfuyuan@...inos.cn>
Subject: RE: [PATCH] drm/xe/hdcp: Fix logic errors



> -----Original Message-----
> From: dri-devel <dri-devel-bounces@...ts.freedesktop.org> On Behalf Of
> 1064094935@...com
> Sent: Monday, October 28, 2024 3:13 PM
> To: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: Vivi, Rodrigo <rodrigo.vivi@...el.com>; De Marchi, Lucas
> <lucas.demarchi@...el.com>; Thomas <thomas.hellstrom@...ux.intel.com>;
> Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Maxime Ripard
> <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>;
> David Airlie <airlied@...il.com>; Simona Vetter <simona@...ll.ch>; intel-
> gfx@...ts.freedesktop.org; intel-xe@...ts.freedesktop.org; dri-
> devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; pengfuyuan
> <pengfuyuan@...inos.cn>
> Subject: [PATCH] drm/xe/hdcp: Fix logic errors
> 
> From: pengfuyuan <pengfuyuan@...inos.cn>
> 
> Here the gsc struct null pointer check should use '||' instead of '&&'.
> 
> Fix the following patches:
>     drm/xe/hdcp: Check GSC structure validity
> 

This fix has already been sent
https://patchwork.freedesktop.org/series/140291/

Regards,
Suraj Kandpal

> Signed-off-by: pengfuyuan <pengfuyuan@...inos.cn>
> ---
>  drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> index 6619a40aed15..f4332f06b6c8 100644
> --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> @@ -42,7 +42,7 @@ bool intel_hdcp_gsc_check_status(struct xe_device *xe)
>  	struct xe_gsc *gsc = &gt->uc.gsc;
>  	bool ret = true;
> 
> -	if (!gsc && !xe_uc_fw_is_enabled(&gsc->fw)) {
> +	if (!gsc || !xe_uc_fw_is_enabled(&gsc->fw)) {
>  		drm_dbg_kms(&xe->drm,
>  			    "GSC Components not ready for HDCP2.x\n");
>  		return false;
> --
> 2.25.1