linux-kernel - Re: [PATCH 1/2] dt-bindings: trivial-devices: add ltp8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85afa3f3-1e6b-4f05-87f4-24c3aa309b66@roeck-us.net>
Date: Tue, 29 Oct 2024 07:04:09 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Peter Yin <peteryin.openbmc@...il.com>,
 Noah Wang <noahwang.wang@...look.com>, Marek Vasut <marex@...x.de>,
 Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH 1/2] dt-bindings: trivial-devices: add ltp8800

On 10/29/24 06:01, Cedric Encarnacion wrote:
> Add Analog Devices LTP8800-1A, LTP8800-2, and LTP8800-4A DC/DC μModule
> regulator.
> 
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>
> ---
>   Documentation/devicetree/bindings/trivial-devices.yaml | 6 ++++++
>   MAINTAINERS                                            | 5 +++++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index bd784f6bb38b..efd959708c75 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -43,6 +43,12 @@ properties:
>             - adi,adp5589
>               # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
>             - adi,lt7182s
> +            # Analog Devices LTP8800-1A 150A, 54V DC/DC μModule regulator
> +          - adi,ltp8800-1a
> +            # Analog Devices LTP8800-2 135A, 54V DC/DC μModule regulator
> +          - adi,ltp8800-2
> +            # Analog Devices LTP8800-4A 200A, 54V DC/DC μModule regulator
> +          - adi,ltp8800-4a

I don't immediately see why this chip would warrant three entries instead of just
"adi,ltp8800". Programming for all chips is the same. The only difference is
the power rating.

Guenter

>               # AMS iAQ-Core VOC Sensor
>             - ams,iaq-core
>               # Temperature monitoring of Astera Labs PT5161L PCIe retimer
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ca7e827da33e..a6abf7243b94 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13555,6 +13555,11 @@ S:	Maintained
>   F:	Documentation/devicetree/bindings/iio/light/liteon,ltr390.yaml
>   F:	drivers/iio/light/ltr390.c
>   
> +LTP8800 HARDWARE MONITOR DRIVER
> +M:	Cedric Encarnacion <cedricjustine.encarnacion@...log.com>
> +L:	linux-hwmon@...r.kernel.org
> +S:	Supported
> +
>   LYNX 28G SERDES PHY DRIVER
>   M:	Ioana Ciornei <ioana.ciornei@....com>
>   L:	netdev@...r.kernel.org