linux-kernel - Re:Re:Re: [PATCH] arm64/Kconfig: introduce GENERIC_ISA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f60ff1f.1d51.192d5fe6248.Coremail.huanglei814@163.com>
Date: Tue, 29 Oct 2024 09:57:51 +0800 (CST)
From: huanglei  <huanglei814@....com>
To: "Will Deacon" <will@...nel.org>
Cc: catalin.marinas@....com, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, huanglei <huanglei@...inos.cn>
Subject: Re:Re:Re: [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA

   There was a slight word spelling error in the previous reply， Now correct it.

 Even if MAX_DMA_CHANNELS is not defined, as long as GENERIC_ISA_DMA is enabled， request_dma/free_dma  function will also be exported, and other modules using these two interfaces will not encounter link errors.
I don't know why others haven't noticed, but I discovered it when debugging pcie parallel port drivers.  And the arm/Kconfig  has been around for a long time.

Best regards!

>At 2024-10-28 22:05:45, "Will Deacon" <will@...nel.org> wrote:
>>On Fri, Oct 25, 2024 at 09:16:41AM +0800, huanglei814 wrote:
>>> From: huanglei <huanglei@...inos.cn>
>>> 
>>> Enable GENERIC_ISA_DMA feature on arm64 platform,
>>> thus, request_dma and free_dma interface can be export.
>>> and driver modules can use the this interfaces on arm64
>>> platform.
>>> 
>>> Currently, many pcie parallel port drivers still use these
>>> interfaces when ported to arm64 platform.
>>
>>Why has it taken so long for anybody to notice?
>>
>>> Signed-off-by: huanglei <huanglei@...inos.cn>
>>> ---
>>>  arch/arm64/Kconfig | 3 +++
>>>  1 file changed, 3 insertions(+)
>>> 
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index fd9df6dcc593..986eb251f68f 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -367,6 +367,9 @@ config GENERIC_CSUM
>>>  config GENERIC_CALIBRATE_DELAY
>>>  	def_bool y
>>>  
>>> +config GENERIC_ISA_DMA
>>> +	def_bool y
>>> +
>>
>>Does this actually do anything without MAX_DMA_CHANNELS defined?
>>
>>Will