[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <26ed8fbb.1809.192d5ef13e5.Coremail.huanglei814@163.com>
Date: Tue, 29 Oct 2024 09:41:08 +0800 (CST)
From: huanglei <huanglei814@....com>
To: "Will Deacon" <will@...nel.org>
Cc: catalin.marinas@....com, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, huanglei <huanglei@...inos.cn>
Subject: Re:Re: [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA
Even if MAX_SMA_CANNELS is not defined, as long as GENETIC-SIA_DMA is enabled, request_rma/free_rma function will also be exported, and other modules using these two interfaces will not encounter link errors.
I don't know why others haven't noticed, but I discovered it when debugging pcie parallel port drivers. And the arm/Kconfig has been around for a long time.
Best regards!
At 2024-10-28 22:05:45, "Will Deacon" <will@...nel.org> wrote:
>On Fri, Oct 25, 2024 at 09:16:41AM +0800, huanglei814 wrote:
>> From: huanglei <huanglei@...inos.cn>
>>
>> Enable GENERIC_ISA_DMA feature on arm64 platform,
>> thus, request_dma and free_dma interface can be export.
>> and driver modules can use the this interfaces on arm64
>> platform.
>>
>> Currently, many pcie parallel port drivers still use these
>> interfaces when ported to arm64 platform.
>
>Why has it taken so long for anybody to notice?
>
>> Signed-off-by: huanglei <huanglei@...inos.cn>
>> ---
>> arch/arm64/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index fd9df6dcc593..986eb251f68f 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -367,6 +367,9 @@ config GENERIC_CSUM
>> config GENERIC_CALIBRATE_DELAY
>> def_bool y
>>
>> +config GENERIC_ISA_DMA
>> + def_bool y
>> +
>
>Does this actually do anything without MAX_DMA_CHANNELS defined?
>
>Will
Powered by blists - more mailing lists