linux-kernel - Re: [PATCH] platform/x86/amd/hsmp: fix compile-testing without CONFiG_AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029151149.GMZyD7NakGOHgkEw4f@fat_crate.local>
Date: Tue, 29 Oct 2024 16:11:49 +0100
From: Borislav Petkov <bp@...en8.de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Mario Limonciello <mario.limonciello@....com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Yazen Ghannam <yazen.ghannam@....com>,
	Suma Hegde <suma.hegde@....com>,
	Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86/amd/hsmp: fix compile-testing without
 CONFiG_AMD_NB

On Tue, Oct 29, 2024 at 02:39:41PM +0200, Ilpo Järvinen wrote:
> I don't like this very wording because what the code very much does is 
> NULL check on node_to_amd_nb() which leads to immediate failure of 
> .probe(). (We don't call other deferences after a NULL check "NULL pointer 
> dereference" either so none is introduced by this patch, IMO.)

I was wondering that too: where does this line

	 sock->root                      = node_to_amd_nb(i)->root;

quoted by gcc come from?

IOW, what is the correct Fixes: tag?

The commit 7d3135d16356 ("platform/x86/amd/hsmp: Create separate ACPI, plat and common drivers

is only in next AFAICT, so I'll drop the Fixes: tag when sending...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette