linux-kernel - Re: [PATCH] selftests/watchdog-test: Fix system accidentally reset after watchdog-test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9d8f7a6-22a4-4d03-ab1e-e488dfdbbd51@linuxfoundation.org>
Date: Mon, 28 Oct 2024 21:39:26 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Li Zhijian <lizhijian@...itsu.com>, shuah@...nel.org,
 linux-kselftest@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/watchdog-test: Fix system accidentally reset
 after watchdog-test

On 10/28/24 21:13, Li Zhijian wrote:
> When running watchdog-test with 'make run_tests', the watchdog-test will
> be terminated by a timeout signal(SIGTERM) due to the test timemout.
> 
> And then, a system reboot would happen due to watchdog not stop. see
> the dmesg as below:
> ```
> [ 1367.185172] watchdog: watchdog0: watchdog did not stop!
> ```
> 
> Fix it by registering more signals(including SIGTERM) in watchdog-test,
> where its signal handler will stop the watchdog.
> 
> After that
>   # timeout 1 ./watchdog-test
>   Watchdog Ticking Away!
>   .
>   Stopping watchdog ticks...
> 
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
>   tools/testing/selftests/watchdog/watchdog-test.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/watchdog/watchdog-test.c b/tools/testing/selftests/watchdog/watchdog-test.c
> index bc71cbca0dde..a1f506ba5578 100644
> --- a/tools/testing/selftests/watchdog/watchdog-test.c
> +++ b/tools/testing/selftests/watchdog/watchdog-test.c
> @@ -334,7 +334,13 @@ int main(int argc, char *argv[])
>   
>   	printf("Watchdog Ticking Away!\n");
>   
> +	/*
> +	 * Register the signals
> +	 */
>   	signal(SIGINT, term);
> +	signal(SIGTERM, term);
> +	signal(SIGKILL, term);
> +	signal(SIGQUIT, term);
>   
>   	while (1) {
>   		keep_alive();


Thank you applied to kselftest fixes for next rc.

thanks,
-- Shuah