linux-kernel - RE: [PATCH for-next v8 0/6] On-Demand Paging on SoftRoCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OS3PR01MB9865DA0EAFDCF89DB9AB2D9AE54B2@OS3PR01MB9865.jpnprd01.prod.outlook.com>
Date: Tue, 29 Oct 2024 05:43:26 +0000
From: "Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@...itsu.com>
To: 'Jason Gunthorpe' <jgg@...pe.ca>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"leon@...nel.org" <leon@...nel.org>, "zyjzyj2000@...il.com"
	<zyjzyj2000@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rpearsonhpe@...il.com"
	<rpearsonhpe@...il.com>, "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
Subject: RE: [PATCH for-next v8 0/6] On-Demand Paging on SoftRoCE

On Fri, Oct 18, 2024 4:28 AM Jason Gunthorpe wrote:
> On Wed, Oct 09, 2024 at 10:58:57AM +0900, Daisuke Matsuda wrote:
> > This patch series implements the On-Demand Paging feature on SoftRoCE(rxe)
> > driver, which has been available only in mlx5 driver[1] so far.
> >
> > This series has been blocked because of the hang issue of srp 002 test[2],
> > which was believed to be caused after applying the commit 9b4b7c1f9f54
> > ("RDMA/rxe: Add workqueue support for rxe tasks"). My patches are dependent
> > on the commit because the ODP feature requires sleeping in kernel space,
> > and it is impossible with the former tasklet implementation.
> >
> > According to the original reporter[3], the hang issue is already gone in
> > v6.10. Additionally, tasklet is marked deprecated[4]. I think the rxe
> > driver is ready to accept this series since there is no longer any reason
> > to consider reverting back to the old tasklet.
> 
> Okay, and it seems we are just ignoring the rxe bugs these days, so
> why not? Lets look at it

Hi Jason,

What we have seen so far suggests that the hang is derived from a potential timing issue in srp drivers.
I believe it cannot be a reason to delay this feature indefinitely.

However, I understand your stance as a maintainer is not wrong. It is natural you want to improve
overall quality of the infiniband subsystem, including the ULP drivers. I am committed to
maintaining and improving the rxe and underlying drivers, but I am sorry that I cannot take
the enough time to delve into the other components right now.

I must leave it to you whether to continue to block my patchset or not.
You are the maintainer and have the final word on it.

Thanks,
Daisuke Matsuda

> 
> Jason