[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241029065800.zktj76ut4le2fosg@lcpd911>
Date: Tue, 29 Oct 2024 12:28:00 +0530
From: Dhruva Gole <d-gole@...com>
To: Markus Schneider-Pargmann <msp@...libre.com>
CC: Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
Marc Kleine-Budde
<mkl@...gutronix.de>,
Vincent Mailhol <mailhol.vincent@...adoo.fr>,
"David S.
Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub
Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring
<robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra
<vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, <linux-can@...r.kernel.org>,
<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
Matthias Schiffer
<matthias.schiffer@...tq-group.com>,
Vishal Mahaveer <vishalm@...com>, Kevin
Hilman <khilman@...libre.com>,
Simon Horman <horms@...nel.org>,
Krzysztof
Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v5 1/9] dt-bindings: can: m_can: Add wakeup properties
On Oct 28, 2024 at 18:38:07 +0100, Markus Schneider-Pargmann wrote:
> m_can can be a wakeup source on some devices. Especially on some of the
> am62* SoCs pins, connected to m_can in the mcu, can be used to wakeup
> the SoC.
>
> The wakeup-source property defines on which devices m_can can be used
> for wakeup.
>
> The pins associated with m_can have to have a special configuration to
> be able to wakeup the SoC. This configuration is described in the wakeup
> pinctrl state while the default state describes the default
> configuration.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> ---
> .../devicetree/bindings/net/can/bosch,m_can.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index c4887522e8fe97c3947357b4dbd4ecf20ee8100a..0c1f9fa7371897d45539ead49c9d290fb4966f30 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -106,6 +106,22 @@ properties:
> maximum: 32
> minItems: 1
>
> + pinctrl-0:
> + description: Default pinctrl state
> +
> + pinctrl-1:
> + description: Wakeup pinctrl state
> +
> + pinctrl-names:
> + description:
> + When present should contain at least "default" describing the default pin
> + states. The second state called "wakeup" describes the pins in their
> + wakeup configuration required to exit sleep states.
> + minItems: 1
> + items:
> + - const: default
> + - const: wakeup
> +
> power-domains:
> description:
> Power domain provider node and an args specifier containing
> @@ -122,6 +138,8 @@ properties:
> minItems: 1
> maxItems: 2
>
> + wakeup-source: true
> +
Reviewed-by: Dhruva Gole <d-gole@...com>
--
Best regards,
Dhruva Gole
Texas Instruments Incorporated
Powered by blists - more mailing lists