lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <TY3PR01MB11346805C5D524D264669D178864B2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Tue, 29 Oct 2024 06:58:27 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Liu Ying <victor.liu@....com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
CC: "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>, "rfoss@...nel.org"
	<rfoss@...nel.org>, laurent.pinchart <laurent.pinchart@...asonboard.com>,
	"jonas@...boo.se" <jonas@...boo.se>, "jernej.skrabec@...il.com"
	<jernej.skrabec@...il.com>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"quic_jesszhan@...cinc.com" <quic_jesszhan@...cinc.com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"catalin.marinas@....com" <catalin.marinas@....com>, "will@...nel.org"
	<will@...nel.org>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "hverkuil@...all.nl" <hverkuil@...all.nl>,
	"tomi.valkeinen@...asonboard.com" <tomi.valkeinen@...asonboard.com>,
	"quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
	"geert+renesas@...der.be" <geert+renesas@...der.be>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>, "arnd@...db.de"
	<arnd@...db.de>, "nfraprado@...labora.com" <nfraprado@...labora.com>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>, "sam@...nborg.org"
	<sam@...nborg.org>, "marex@...x.de" <marex@...x.de>
Subject: RE: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS
 display common properties

Hi Liu Ying,

> -----Original Message-----
> From: Liu Ying <victor.liu@....com>
> Sent: 29 October 2024 06:17
> Subject: Re: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS display common properties
> 
> On 10/28/2024, Liu Ying wrote:
> > Dual-link LVDS displays receive odd pixels and even pixels separately
> > from dual LVDS links.  One link receives odd pixels and the other
> > receives even pixels.  Some of those displays may also use only one
> > LVDS link to receive all pixels, being odd and even agnostic.
> > Document common properties for those displays by extending LVDS
> > display common properties defined in lvds.yaml.
> >
> > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Signed-off-by: Liu Ying <victor.liu@....com>
> > ---
> > v4:
> > * Squash change for advantech,idk-2121wr.yaml and
> >   panel-simple-lvds-dual-ports.yaml with lvds-dual-ports.yaml.  (Rob)
> > * Improve description in lvds-dual-ports.yaml.  (Krzysztof)
> >
> > v3:
> > * New patch.  (Dmitry)
> >
> >  .../bindings/display/lvds-dual-ports.yaml     | 76 +++++++++++++++++++
> >  .../display/panel/advantech,idk-2121wr.yaml   | 14 +---
> >  .../panel/panel-simple-lvds-dual-ports.yaml   | 20 +----
> >  3 files changed, 78 insertions(+), 32 deletions(-)  create mode
> > 100644 Documentation/devicetree/bindings/display/lvds-dual-ports.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/lvds-dual-ports.yaml
> > b/Documentation/devicetree/bindings/display/lvds-dual-ports.yaml
> > new file mode 100644
> > index 000000000000..5f7a30640404
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/lvds-dual-ports.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/lvds-dual-ports.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Dual-link LVDS Display Common Properties
> > +
> > +maintainers:
> > +  - Liu Ying <victor.liu@....com>
> > +
> > +description: |
> > +  Common properties for LVDS displays with dual LVDS links. Extend
> > +LVDS display
> > +  common properties defined in lvds.yaml.
> > +
> > +  Dual-link LVDS displays receive odd pixels and even pixels
> > + separately from  the dual LVDS links. One link receives odd pixels
> > + and the other receives  even pixels. Some of those displays may also
> > + use only one LVDS link to  receive all pixels, being odd and even agnostic.
> > +
> > +allOf:
> > +  - $ref: lvds.yaml#
> > +
> > +properties:
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/$defs/port-base
> > +        unevaluatedProperties: false
> > +        description: the first LVDS input link
> > +
> > +        properties:
> > +          dual-lvds-odd-pixels:
> > +            type: boolean
> > +            description: the first LVDS input link for odd pixels
> > +
> > +          dual-lvds-even-pixels:
> > +            type: boolean
> > +            description: the first LVDS input link for even pixels
> > +
> > +        oneOf:
> > +          - required: [dual-lvds-odd-pixels]
> > +          - required: [dual-lvds-even-pixels]
> > +          - properties:
> > +              dual-lvds-odd-pixels: false
> > +              dual-lvds-even-pixels: false
> > +
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/$defs/port-base
> > +        unevaluatedProperties: false
> > +        description: the second LVDS input link
> > +
> > +        properties:
> > +          dual-lvds-odd-pixels:
> > +            type: boolean
> > +            description: the second LVDS input link for odd pixels
> > +
> > +          dual-lvds-even-pixels:
> > +            type: boolean
> > +            description: the second LVDS input link for even pixels
> > +
> > +        oneOf:
> > +          - required: [dual-lvds-odd-pixels]
> > +          - required: [dual-lvds-even-pixels]
> > +          - properties:
> > +              dual-lvds-odd-pixels: false
> > +              dual-lvds-even-pixels: false
> 
> Hmm, I should require port@0 or port@1.

For dual LVDS, you need 3 ports as common use case

2 input ports and 1 outport and all are required properties.

Cheers,
Biju

> Will wait a while for comments and add this in next version.
> 
> --8<--
>     anyOf:
>       - required:
>           - port@0
>       - required:
>           - port@1
> --8<--
> 
> > +
> > +required:
> > +  - ports
> > +
> > +additionalProperties: true
> > +
> > +...
> 
> [...]
> 
> --
> Regards,
> Liu Ying

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ