linux-kernel - Re: [PATCH 10/11] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed81fbc3-7a15-4468-963e-e81c668f8978@quicinc.com>
Date: Wed, 30 Oct 2024 23:34:22 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Abhishek Sahu
	<absahu@...eaurora.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Ajit Pandey
	<quic_ajipan@...cinc.com>,
        Imran Shaik <quic_imrashai@...cinc.com>,
        "Jagadeesh Kona" <quic_jkona@...cinc.com>,
        Stephen Boyd
	<sboyd@...eaurora.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 10/11] clk: qcom: videocc-qcs615: Add QCS615 video clock
 controller driver



On 10/19/2024 2:01 AM, Dmitry Baryshkov wrote:
>> +static const struct pll_vco video_cc_pll0_vco[] = {
>> +	{ 500000000, 1000000000, 2 },
>> +};
>> +
>> +/* 600MHz configuration */
>> +static struct alpha_pll_config video_pll0_config = {
>> +	.l = 0x1F,
> lowercase the hex, please. LGTM otherwise.
> 

Will fix in the next patch.

>> +	.alpha_hi = 0x40,
>> +	.alpha = 0x00,
>> +	.alpha_en_mask = BIT(24),

-- 
Thanks & Regards,
Taniya Das.