[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241030181906.GI1350452@ZenIV>
Date: Wed, 30 Oct 2024 18:19:06 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
linux-fsdevel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] xattr: remove redundant check on variable err
On Wed, Oct 30, 2024 at 06:01:40PM +0000, Colin Ian King wrote:
> Curretly in function generic_listxattr the for_each_xattr_handler loop
> checks err and will return out of the function if err is non-zero.
> It's impossible for err to be non-zero at the end of the function where
> err is checked again for a non-zero value. The final non-zero check is
> therefore redundant and can be removed.
I'd suggest taking err itself into the loop body, while we are at it...
Powered by blists - more mailing lists